Skip to content

Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jestavo1 wants to merge 7 commits into
base: main
Choose a base branch
from
+179 −7
Open

Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98350a3
adding form contents to index.html
Jestavo1 Sep 17, 2026
8b38273
adding css file
Jestavo1 Sep 17, 2026
38f5f59
adding properties
Jestavo1 Sep 17, 2026
57f8663
linking css to html
Jestavo1 Sep 17, 2026
ba865a1
refactor: separate T-shirt colour and size fields in the form
Jestavo1 Sep 23, 2026
231d9db
fix: remove extraneous code block from index.html
Jestavo1 Sep 23, 2026
7dccd6a
fix: remove extraneous code block from index.html
Jestavo1 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 67 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop

@iscmiguelsamaniego iscmiguelsamaniego Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great form structure! Quick check: take a second look at your stylesheet link (styel.css). Also, why might grouping fields with <fieldset> and <legend> improve accessibility?

Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,82 @@
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="styel.css" />

@cjyuan cjyuan Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style sheet filename is typically spelled style.css.

@cjyuan cjyuan Sep 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the CSS file to style.css?

</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form>
<fieldset>
<legend>Customer Information</legend>
<p>
<label for="customerName">Customer Name</label>
<input
id="customerName"
name="customerName"
type="text"
pattern=".*\S.*\S.*"
placeholder="username"
required
/>
</p>
<p>
<label for="emailAddress">Email Address</label>
<input
id="emailAddress"
name="emailAddress"
type="email"
placeholder="email"
required
/>
</p>
</fieldset>

<fieldset>
<legend>T-shirt Colour</legend>

<p>
<input type="radio" id="red" name="colour" value="red" required />
<label for="red">Red</label>
</p>

<p>
<input type="radio" id="green" name="colour" value="green" />
<label for="green">Green</label>
</p>

<p>
<input type="radio" id="blue" name="colour" value="blue" />
<label for="blue">Blue</label>
</p>
</fieldset>

<fieldset>
<legend>T-shirt Size</legend>

<p>
<label for="size">Choose a size</label>
<select id="size" name="size" required>
<option value="" disabled selected>Select Size</option>
<option value="Xsmall">XS</option>
<option value="Small">S</option>
<option value="Medium">M</option>
<option value="Large">L</option>
<option value="XLarge">XL</option>
<option value="XXLarge">XXL</option>
</select>
</p>
</fieldset>


<input type="submit" value="Submit" />
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>

<p>By Gustarv Nchitu</p>
</footer>
</body>
</html>
112 changes: 112 additions & 0 deletions Form-Controls/styel.css
View file
Open in desktop

@iscmiguelsamaniego iscmiguelsamaniego Sep 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic CSS! The gradients and focus states look very clean.

Quick question: your text inputs use width: 100%, but the <select> dropdown doesn't. How might adding width: 100% to the <select> improve visual consistency?

Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
```css
body {
font-family: "Segoe UI", Tahoma, sans-serif;
background: linear-gradient(135deg, #e8f0ff, #f8faff);
color: #243447;
margin: 0;
min-height: 100vh;
}

header {
background: linear-gradient(120deg, #4a69bd, #6a89cc);
color: #ffffff;
text-align: center;
padding: 35px 20px;
box-shadow: 0 4px 12px rgba(0, 0, 0, 0.15);
}

header h1 {
margin: 0;
font-size: 2rem;
letter-spacing: 1px;
}

main {
max-width: 700px;
margin: 45px auto;
padding: 0 25px;
}

fieldset {
background-color: #ffffff;
border: none;
border-left: 5px solid #4a69bd;
border-radius: 12px;
padding: 28px;
margin-bottom: 25px;
box-shadow: 0 8px 20px rgba(74, 105, 189, 0.12);
}

legend {
font-weight: 700;
color: #4a69bd;
padding: 0 12px;
font-size: 1.1rem;
}

fieldset p {
margin-bottom: 20px;
line-height: 1.5;
}

input[type="text"],
input[type="email"] {
display: block;
width: 100%;
box-sizing: border-box;
padding: 13px 15px;
margin-top: 8px;
border: 2px solid #d9e2f3;
border-radius: 8px;
background-color: #f9fbff;
color: #243447;
transition: border-color 0.2s ease, box-shadow 0.2s ease;
}

select {
display: block;
margin-top: 8px;
padding: 13px 15px;
border: 2px solid #d9e2f3;
border-radius: 8px;
background-color: #f9fbff;
color: #243447;
cursor: pointer;
}

input[type="submit"] {
background: linear-gradient(120deg, #4a69bd, #3867d6);
color: #ffffff;
font-weight: 700;
font-size: 1rem;
padding: 13px 26px;
border: none;
border-radius: 8px;
cursor: pointer;
box-shadow: 0 5px 12px rgba(56, 103, 214, 0.25);
transition: transform 0.2s ease, box-shadow 0.2s ease;
}

input[type="submit"]:hover {
transform: translateY(-2px);
box-shadow: 0 8px 16px rgba(56, 103, 214, 0.3);
}

input[type="text"]:focus,
input[type="email"]:focus,
input[type="radio"]:focus,
input[type="submit"]:focus,
select:focus {
outline: none;
border-color: #4a69bd;
box-shadow: 0 0 0 4px rgba(74, 105, 189, 0.2);
}

footer {
text-align: center;
font-weight: 600;
color: #65748b;
padding: 20px;
margin-top: 20px;
}
```
Loading