Skip to content

Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls - #1533

Open
Jestavo1 wants to merge 7 commits into
CodeYourFuture:mainfrom
Jestavo1:feature/form-controls
Open

Jestavo1 wants to merge 7 commits into
CodeYourFuture:mainfrom
Jestavo1:feature/form-controls

Conversation

@Jestavo1

@Jestavo1 Jestavo1 commented Sep 17, 2026 •

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

TaskCode

CYF-1004

Changelist

-I created css file
-i created html forms
-i used semantic html

@github-actions

This comment has been minimized.

@netlify

netlify Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7dccd6a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab40bdaeb714500080dffa4
😎 Deploy Preview https://deploy-preview-1533--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Jestavo1 Jestavo1 changed the title form controls Manchster | 26-ITP-Sept | Gustarv Nchitu | Sprint 1| Form Controls Sep 17, 2026
@github-actions

This comment has been minimized.

@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 17, 2026
@Jestavo1 Jestavo1 changed the title Manchster | 26-ITP-Sept | Gustarv Nchitu | Sprint 1| Form Controls Manchester | 26-ITP-Sept | Gustarv Nchitu | Sprint 1| Form Controls Sep 18, 2026
@github-actions

This comment has been minimized.

@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@Jestavo1 Jestavo1 changed the title Manchester | 26-ITP-Sept | Gustarv Nchitu | Sprint 1| Form Controls Manchester | 26-Sep-ITP| Gustarv Nchitu | Sprint 1| Form Controls Sep 18, 2026
@github-actions

This comment has been minimized.

@Jestavo1 Jestavo1 changed the title Manchester | 26-Sep-ITP| Gustarv Nchitu | Sprint 1| Form Controls Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls Sep 18, 2026
@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 18, 2026
@Jestavo1 Jestavo1 changed the title Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls Manchester | 26-ITP-Sep | Gustarv Nchitu | Sprint 1 | Form Controls Sep 18, 2026
@Jestavo1 Jestavo1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 18, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good and well formatted.

  • It looks slightly inconsistent to have a label for size input but nothing for the radio buttons. Could you use an AI to find out how you could improve the design?

Image
  • The PR template has a "Changelist" section heading. Could you restore it in your PR description?

Comment thread Form-Controls/index.html
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="stylesheet" href="styel.css" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style sheet filename is typically spelled style.css.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the CSS file to style.css?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 22, 2026
@Jestavo1 Jestavo1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2026

@iscmiguelsamaniego iscmiguelsamaniego left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic CSS! Could you please kindly check the filename styel.css in your link tag? Renaming it to style.css will ensure it loads correctly. Great work—approved!

Comment thread Form-Controls/index.html

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great form structure! Quick check: take a second look at your stylesheet link (styel.css). Also, why might grouping fields with <fieldset> and <legend> improve accessibility?

Comment thread Form-Controls/styel.css

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic CSS! The gradients and focus states look very clean.

Quick question: your text inputs use width: 100%, but the <select> dropdown doesn't. How might adding width: 100% to the <select> improve visual consistency?

@cjyuan

cjyuan commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@Jestavo1 Could you also respond to all comments in addition to making change?
Suggestion: Use AI to explore "how to respond to comments in a PR".

If you could address and respond to all my previous comments, I would mark this PR as "Complete".

Note: To create unordered list item in Markdown, you need to include a space between - and the item's text. Space matter in Markdown syntax

@iscmiguelsamaniego Thanks for giving additional feedback. I think the usual practice in ITP is to have only one reviewer per PR.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants