Conversation
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| <title>My form exercise</title> | ||
| <meta name="description" content="" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="stylesheet" href="styel.css" /> |
There was a problem hiding this comment.
The style sheet filename is typically spelled style.css.
There was a problem hiding this comment.
Could you rename the CSS file to style.css?
iscmiguelsamaniego
left a comment
There was a problem hiding this comment.
Fantastic CSS! Could you please kindly check the filename styel.css in your link tag? Renaming it to style.css will ensure it loads correctly. Great work—approved!
There was a problem hiding this comment.
Great form structure! Quick check: take a second look at your stylesheet link (styel.css). Also, why might grouping fields with <fieldset> and <legend> improve accessibility?
There was a problem hiding this comment.
Fantastic CSS! The gradients and focus states look very clean.
Quick question: your text inputs use width: 100%, but the <select> dropdown doesn't. How might adding width: 100% to the <select> improve visual consistency?
|
@Jestavo1 Could you also respond to all comments in addition to making change? If you could address and respond to all my previous comments, I would mark this PR as "Complete". Note: To create unordered list item in Markdown, you need to include a space between @iscmiguelsamaniego Thanks for giving additional feedback. I think the usual practice in ITP is to have only one reviewer per PR. |


Learners, PR Template
Self checklist
TaskCode
CYF-1004
Changelist
-I created css file
-i created html forms
-i used semantic html