Skip to content

feat(generated): Authorization (batch c64ce1e7) - #734

Merged
workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-c64ce1e7
Sep 24, 2026
Merged

workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-c64ce1e7

Conversation

@workos-sdk-automation

Copy link
Copy Markdown
Contributor

Summary

Regenerated SDK from spec changes.

Triggered by workos/openapi-spec@e2873c2

@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 24, 2026
@workos-sdk-automation
workos-sdk-automation Bot requested review from a team as code owners September 24, 2026 14:13
@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR should not merge until the existing workos.pipes.models.ConnectedAccountInput import path is restored.

Findings

  1. P1 Pipes model import removed ▶
  2. P2 Wildcard imports expose unrelated names ▶
  3. P2 Populated source group remains untested ▶
Fix with agent prompt
### Issue 1
src/workos/pipes/models/__init__.py:3
Callers that use `from workos.pipes.models import ConnectedAccountInput` could import it before this change. The re-export is now gone, so that import raises `ImportError`. Please restore the existing import path.

### Issue 2
src/workos/common/models/__init__.py:57
The new wildcard imports also export names such as `Enum`, `Literal`, and `TypeAlias` from model modules. The wildcard import in `workos.common` passes those names on again. This makes the public namespace harder to use and maintain; explicit model exports would keep unrelated names out.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

### Issue 3
tests/test_authorization_models_round_trip.py:529-535
This test round-trips the group model by itself, but every source and role-assignment fixture has `group: null`. A test with a populated group nested in a role assignment would cover the new deserialization and serialization path, so a regression there does not go unnoticed.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The regeneration adds a nullable group to authorization role-assignment sources and updates model exports and fixtures.

  • The new group model and its standalone round trip are covered, but a populated group nested in a role assignment is not.
  • The export changes remove an existing Pipes import path and broaden common-model wildcard exports.

Reviews (1) · Last reviewed commit: "chore(generated): add release notes frag..."

@@ -1,9 +1,6 @@
# This file is auto-generated by oagen. Do not edit.

from workos.common.models.connected_account import ConnectedAccount as ConnectedAccount

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Pipes model import removed
Callers that use from workos.pipes.models import ConnectedAccountInput could import it before this change. The re-export is now gone, so that import raises ImportError. Please restore the existing import path.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/pipes/models/__init__.py
Line: 3

Comment:
**Pipes model import removed**
Callers that use `from workos.pipes.models import ConnectedAccountInput` could import it before this change. The re-export is now gone, so that import raises `ImportError`. Please restore the existing import path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

from .agent_instance_created_data import (
AgentInstanceCreatedData as AgentInstanceCreatedData,
)
from .agent_instance_created_data_type import *

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Wildcard imports expose unrelated names
The new wildcard imports also export names such as Enum, Literal, and TypeAlias from model modules. The wildcard import in workos.common passes those names on again. This makes the public namespace harder to use and maintain; explicit model exports would keep unrelated names out.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/common/models/__init__.py
Line: 57

Comment:
**Wildcard imports expose unrelated names**
The new wildcard imports also export names such as `Enum`, `Literal`, and `TypeAlias` from model modules. The wildcard import in `workos.common` passes those names on again. This makes the public namespace harder to use and maintain; explicit model exports would keep unrelated names out.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +529 to +535
def test_user_role_assignment_source_group_round_trip(self):
data = load_fixture("user_role_assignment_source_group.json")
instance = UserRoleAssignmentSourceGroup.from_dict(data)
serialized = instance.to_dict()
assert serialized == data
restored = UserRoleAssignmentSourceGroup.from_dict(serialized)
assert restored.to_dict() == serialized

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Populated source group remains untested
This test round-trips the group model by itself, but every source and role-assignment fixture has group: null. A test with a populated group nested in a role assignment would cover the new deserialization and serialization path, so a regression there does not go unnoticed.

Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/test_authorization_models_round_trip.py
Line: 529-535

Comment:
**Populated source group remains untested**
This test round-trips the group model by itself, but every source and role-assignment fixture has `group: null`. A test with a populated group nested in a role assignment would cover the new deserialization and serialization path, so a regression there does not go unnoticed.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@workos-sdk-automation
workos-sdk-automation Bot merged commit 0037bc3 into main Sep 24, 2026
11 checks passed
@workos-sdk-automation
workos-sdk-automation Bot deleted the oagen/batch-c64ce1e7 branch September 24, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autogenerated Autogenerated code or content

Development

Successfully merging this pull request may close these issues.

0 participants