fix(efficacy): an empty final message carries the judge CLI's cause (#1768) - #1835
Merged
Merged
Conversation
…1768) A CLI refused by the model creates its final-message file and leaves it empty, so the failure read 'not JSON:' and nothing more; the cause was only in what the CLI printed. Both failure branches now carry the tail of it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1768.
A
codex execrefused by the model creates its--output-last-messagefilebefore the call and leaves it empty.
judge_bundlethen reportedthe final message was not JSON:and nothing more, and the cause, which the CLI printedto standard error, was dropped.
Change
the final message was empty(ornot JSON: <text>) followed bythe CLI said: <tail>, the last400 characters of what the CLI printed.
cli_saidreads that tail for both failure branches, the missing-file oneincluded, which already carried it inline.
claudebackend already reports its standard error when it printsnothing; unchanged.
Check
The self test's stand-in CLI gains a refusal mode, set by
FAKE_CODEX_REFUSES: it creates the message file empty, writes the cause tostandard error and exits 1, as the real CLI did. The new check requires the
file to exist and be empty (so the failure is read from the no-JSON branch,
not the missing-file one), the error to say
was empty, and the planted causeto be in it.
Control: with the cause removed from the error (
cli_said(outcome)replacedby
"", landing asserted, reverted from a commit), that check goes FAILED,20/21.
judge.py --self-test21/21. Smoke 33/33. Conformance 22 passed, 0 failed;readings: no other open PR, no off-limits path, and the one existing test
changed is the stand-in CLI, which gains the refusal mode behind an
environment variable and behaves as before without it.
No CHANGELOG entry: the benchmark's tooling is not observable by a consuming
project.
🤖 Generated with Claude Code