Skip to content

improvement(ui): use inline Button for small text actions - #8177

Merged
waleedlatif1 merged 1 commit into
codex/overrides-button-sizingfrom
codex/overrides-inline-text-actions
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/overrides-button-sizingfrom
codex/overrides-inline-text-actions

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use the shared 20px inline Button for log file Download and table New row actions, removing seven local styling overrides.
  • Preserve download navigation, row creation, the lock-reason tooltip, and the table action's aria-disabled guard.
  • Intentional visual changes: Download text grows from 11px to 12px; New row gains 6px horizontal padding on each side and uses the ghost button's secondary resting text colour.

Type of Change

  • Improvement

Testing

  • All 26 workspace type checks, lint, 47 repository audits, and 368 EMCN tests pass.
  • The full design scan removed exactly seven targeted findings (853 to 846 on this PR base), with none added. The committed diff linter reports no findings.
  • Matched before/after browser screenshots and interaction notes cover light and dark rest, hover, and blocked keyboard focus with tooltip. The fixture uses the actual components and PR-base CSS with synthetic data; authenticated routes and backend persistence were not exercised.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 11:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, accessibility, security, or repository-rule issues identified.

Summary

This PR replaces local sizing overrides with the shared inline Button size for two compact workspace actions:

  • Updates the log-file Download action while preserving its existing download handler.
  • Updates the table New row action while preserving row creation, blocked-state tooltip behavior, and the aria-disabled guard.

Reviews (1) · Last reviewed commit: "improvement(ui): use inline Button for s..."

@waleedlatif1
waleedlatif1 merged commit ce888f9 into codex/overrides-button-sizing Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-inline-text-actions branch September 22, 2026 23:45
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after visual review for 070719e (base d583476). These isolated browser fixtures render the actual FileCards and table AddRowButton with EMCN Button, Tooltip, icons, and product CSS from the PR base, using synthetic file/table data. Matching light/dark frames include labeled 3× control crops.

Download stays 20px high; its label changes 11→12px. New row stays 20px high with its 13px label; shared padding adds 6px per side and its resting text uses the ghost secondary color. Enabled row click, blocked no-click with aria-disabled, keyboard/hover tooltip, and the stubbed Download action passed on both sides. Authenticated routes and backend persistence were not exercised.

Light rest, dark rest, New row hover, and blocked keyboard focus/tooltip:
compare-light-blocked-focus
compare-light-row-hover
compare-dark-rest
compare-light-rest

waleedlatif1 pushed a commit that referenced this pull request Sep 23, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(ui): use inline Button for small text actions (#8177)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(emcn): assert responsive icon size map as const

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was previously deployed

1 inactive deployment
Preview 070719e1 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants