Skip to content

refactor(ui): share static API and MCP parameter cards - #8027

Open
BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-remaining-field-cardsfrom
codex/control-fix-parameter-cards
Open

BillLeoutsakosvl346 wants to merge 3 commits into
codex/control-fix-remaining-field-cardsfrom
codex/control-fix-parameter-cards

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

API and MCP parameter editors duplicated the same name/type header and description-card styling. They now use EMCN FieldCard, which shares its frame and body with CollapsibleCard while keeping a non-interactive, always-open header. Existing description controls, values and callbacks are preserved.

Colors, borders, corners, body spacing and badge placement stay the same. Long names use the standard fade and full-value tooltip; MCP settings names align to the other cards at 14px instead of 15px, making that header 2.5px shorter in the browser comparison. Existing collapsible cards retain their appearance and behavior.

Validation: all 26 workspace type/lint checks, import-specifier resolution, mandatory API validation, 355 EMCN tests and 45 relevant consumer tests passed. The external conformance audit removes all three targeted findings and adds none. Twelve field-control subtrees are unchanged. Isolated light/dark browser comparisons cover the migrated cards, long labels, actions and keyboard collapse/reopen; live API saves and MCP deployments were not exercised.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 23, 2026 2:15am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable regressions or outstanding rule violations were identified.

Summary

The PR consolidates static API and MCP parameter editors around a new shared FieldCard, reuses its frame and body in CollapsibleCard, standardizes several icon actions and field-mode toggles, and preserves specialized compact action geometry where needed.

  • Adds an always-open, non-interactive FieldCard with shared card framing and overflow handling.
  • Migrates API and MCP parameter-description cards without changing their values or callbacks.
  • Extracts a reusable FieldModeToggle and adopts standardized icon-button sizing across workflow editor controls.
  • Adds coverage confirming that static field-card content remains visible and non-collapsible.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[FieldCardFrame] --> B[FieldCard]
  A --> C[CollapsibleCard]
  D[FieldCardContent] --> B
  D --> C
  B --> E[API parameter editors]
  B --> F[MCP parameter editors]
  C --> G[Existing collapsible workflow cards]
Loading

Reviews (3) · Last reviewed commit: "fix(ui): preserve specialized tiny actio..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai Please review the current parameter-card changes.

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai Please review the current parameter-card changes.

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

API and MCP deployment parameter shells reuse FieldCard. These representative pairs retain the existing fields, surfaces and density.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

The earlier MCP-settings density proposal is deliberately omitted; it is not the final treatment.

Current PR head checked at posting: de83615667.

Before and after: 8027

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-remaining-field-cards branch from 2d698ae to ffd56d1 Compare September 22, 2026 20:48
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-parameter-cards branch from af1ee02 to b8c83e8 Compare September 22, 2026 20:48
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was successfully deployed

1 active deployment
Preview 99ca82b2 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant