Conversation
Summary: Prevents the RNTester examples in Animated > Transform Styles from exhibiting the issue referenced in [react#43763](react#43763), where rotateX and rotateY show animation artifacting on iOS. ### Root Cause Fabric flattens away the parent view that would normally provide a native layer boundary. iOS Core Animation then processes the rotateX/rotateY 3D layer in the same hierarchy as sibling controls, causing incorrect depth composition and rendering artifacts. ### This PR Modify `TransformStylesExample.js` to add the `isolation: 'isolate'` style on the View wrapper so it is retained in the native stacking context. This doesn't fix the root problem but documents the root cause and a workaround until a framework fix is implemented. Changelog: [Internal] Differential Revision: D121559781
meta-cla
Bot
added
the
CLA Signed
|
@jasozh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121559781. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Prevents the RNTester examples in Animated > Transform Styles from exhibiting the issue referenced in #43763, where rotateX and rotateY show animation artifacting on iOS.
Root Cause
Fabric flattens away the parent view that would normally provide a native layer boundary. iOS Core Animation then processes the rotateX/rotateY 3D layer in the same hierarchy as sibling controls, causing incorrect depth composition and rendering artifacts.
This PR
Modify
TransformStylesExample.jsto add theisolation: 'isolate'style on the View wrapper so it is retained in the native stacking context. This doesn't fix the root problem but documents the root cause and a workaround until a framework fix is implemented.Changelog: [Internal]
Differential Revision: D121559781