Reject deep imports in internal Flow roots (#58674) - #58674
Closed
rubennorte wants to merge 2 commits into
Closed
rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121377261. |
rubennorte
force-pushed
the
export-D121377261
branch
2 times, most recently
from
September 24, 2026 15:14
91c39e0 to
fc90f7d
Compare
Summary: Migrate remaining React Native consumer deep imports to supported root and secondary entrypoints. Keep Jest preset package-internal type imports on OSS-exported implementation paths while preserving runtime mock behavior. Changelog: [Internal] Differential Revision: D121588775
rubennorte
force-pushed
the
export-D121377261
branch
2 times, most recently
from
September 24, 2026 15:47
174cfec to
bae00ed
Compare
Summary: Pull Request resolved: react#58674 Reject unsupported `react-native/*` deep imports in consumer Flow roots while retaining explicit mappings for supported secondary and internal compatibility entrypoints. Keep the Jest preset package-internal type imports and the vendored React Native Windows `useMergeRefs` implementation import because package-relative imports across React Native packages are not supported and the latter preserves callback-ref cleanup semantics. Suppress only those intentional package-internal compatibility imports. Changelog: [Internal] Reviewed By: javache Differential Revision: D121377261
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D121377261
branch
from
September 24, 2026 15:49
bae00ed to
e05a6cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reject unsupported
react-native/*deep imports in consumer Flow roots while retaining explicit mappings for supported secondary and internal compatibility entrypoints.Keep the Jest preset package-internal type imports and the vendored React Native Windows
useMergeRefsimplementation import because package-relative imports across React Native packages are not supported and the latter preserves callback-ref cleanup semantics. Suppress only those intentional package-internal compatibility imports.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D121377261