Conversation
meta-cla
Bot
added
the
CLA Signed
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121188416. |
meta-codesync
Bot
changed the title
@babel/parser to ^7.29.9, @babel/types to ^7.29.8@babel/parser to ^7.29.9, @babel/types to ^7.29.8 (#58641)
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 23, 2026
Summary: This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg `cond ? async (...args) => {} : null`). (I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types) The update brings `babel/types` 7.29.7 -> 7.29.8, requiring regeneration of generated flow types. ~~**The `xplat/js/yarn.lock` version will likely need updating to match, or the Babel types sync test will fail**~~ - I've updated specifiers to bring everyone onto that version. Changelog: [Internal] X-link: react/metro#1958 Test Plan: CI Differential Revision: D121188416 Pulled By: vzaidman
meta-codesync
Bot
force-pushed
the
export-D121188416
branch
from
September 23, 2026 08:46
b11f9fc to
d273371
Compare
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Sep 23, 2026
Summary: Pull Request resolved: #1962 X-link: react/react-native#58641 This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg `cond ? async (...args) => {} : null`). (I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types) The update brings `babel/types` 7.29.7 -> 7.29.8, requiring regeneration of generated flow types. ~~**The `xplat/js/yarn.lock` version will likely need updating to match, or the Babel types sync test will fail**~~ - I've updated specifiers to bring everyone onto that version. Changelog: [Internal] Pull Request resolved: #1958 Test Plan: CI Differential Revision: D121188416 Pulled By: vzaidman
Summary: X-link: react/metro#1962 This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg `cond ? async (...args) => {} : null`). (I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types) The update brings `babel/types` 7.29.7 -> 7.29.8, requiring regeneration of generated flow types. ~~**The `xplat/js/yarn.lock` version will likely need updating to match, or the Babel types sync test will fail**~~ - I've updated specifiers to bring everyone onto that version. Changelog: [Internal] X-link: react/metro#1958 Test Plan: CI Reviewed By: javache Differential Revision: D121188416 Pulled By: vzaidman
meta-codesync
Bot
force-pushed
the
export-D121188416
branch
from
September 23, 2026 12:57
d273371 to
66a70d6
Compare
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Sep 23, 2026
Summary: X-link: react/react-native#58641 This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg `cond ? async (...args) => {} : null`). (I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types) The update brings `babel/types` 7.29.7 -> 7.29.8, requiring regeneration of generated flow types. ~~**The `xplat/js/yarn.lock` version will likely need updating to match, or the Babel types sync test will fail**~~ - I've updated specifiers to bring everyone onto that version. Changelog: [Internal] Test Plan: CI Reviewed By: javache Differential Revision: D121188416 Pulled By: vzaidman
meta-codesync Bot
pushed a commit
to react/metro
that referenced
this pull request
Sep 23, 2026
Summary: Pull Request resolved: #1962 X-link: react/react-native#58641 This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg `cond ? async (...args) => {} : null`). (I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types) The update brings `babel/types` 7.29.7 -> 7.29.8, requiring regeneration of generated flow types. ~~**The `xplat/js/yarn.lock` version will likely need updating to match, or the Babel types sync test will fail**~~ - I've updated specifiers to bring everyone onto that version. Changelog: [Internal] Pull Request resolved: #1958 Test Plan: CI Reviewed By: javache Differential Revision: D121188416 Pulled By: vzaidman
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/metro#1962
This picks up babel/babel#18241, fixing parsing of arrow function params inside ternaries with Flow (eg
cond ? async (...args) => {} : null).(I remember hitting this one internally and not realising where it came from - IIRC it also applies to arrows within conditional types)
The update brings
babel/types7.29.7 -> 7.29.8, requiring regeneration of generated flow types.The- I've updated specifiers to bring everyone onto that version.xplat/js/yarn.lockversion will likely need updating to match, or the Babel types sync test will failChangelog: [Internal]
X-link: react/metro#1958
Test Plan: CI
Reviewed By: javache
Differential Revision: D121188416
Pulled By: vzaidman