Conversation
SourceMap kept one six-element array per mapping segment. Bundled applications have millions of segments, and with --enable-source-maps a parsed map lives for the life of the process: a 63 MB source map with 2.9 million segments retained about 290 MiB of heap. Store the segments in a single Int32Array, six fields per segment, and resolve source URLs and names through per-map tables. Segments are counted before parsing so storage is allocated once, and sorting is skipped when the mappings are already in order. The public API and the objects returned by findEntry() and findOrigin() are unchanged. Signed-off-by: Jacky Zhao <j.zhao2k19@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66261 +/- ##
==========================================
- Coverage 90.30% 90.29% -0.01%
==========================================
Files 789 789
Lines 272880 273012 +132
Branches 52110 52135 +25
==========================================
+ Hits 246418 246515 +97
- Misses 16912 16963 +51
+ Partials 9550 9534 -16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SourceMap kept one six-element array per mapping segment. Bundled applications have millions of segments, and with
--enable-source-mapsthese arrays live for the life of the process. From our prod application, a 63 MB source map with 2.9 million segments retained about 290 MiB of heap.What changed
Disclaimer: this PR was written with the help of Opus 5.5 but I have personally read, reviewed, and validated the changes.