feat(json): add JSON generators - #1079
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
==========================================
+ Coverage 90.77% 91.38% +0.61%
==========================================
Files 221 249 +28
Lines 21267 23253 +1986
Branches 2003 2244 +241
==========================================
+ Hits 19305 21250 +1945
- Misses 1956 1994 +38
- Partials 6 9 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
9.50 MB | 9.50 MB | +129.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 37.5% faster (8.85 s → 5.53 s)
- Peak memory: 16.1% higher (1.56 GB → 1.81 GB)
web Generator
Output size: 60 files changed · net 0 B
File size details
| File | Main | PR | Change |
|---|---|---|---|
assets/SearchBox-Dn4L8Iad.js |
84.60 KB | — | -84.60 KB (-100.0%) |
assets/SearchBox-xWxQEwJG.js |
— | 84.60 KB | +84.60 KB |
assets/dist-Bjw0z_pG.js |
30.42 KB | — | -30.42 KB (-100.0%) |
assets/dist-B6Cxpm1h.js |
— | 30.42 KB | +30.42 KB |
assets/SideBar-8MuLGqIk.js |
25.64 KB | — | -25.64 KB (-100.0%) |
assets/SideBar-CXDS9lwB.js |
— | 25.64 KB | +25.64 KB |
assets/config-ngHjfxzr.js |
24.37 KB | — | -24.37 KB (-100.0%) |
assets/config-Cx-IX3nR.js |
— | 24.37 KB | +24.37 KB |
assets/client-7SazmsOY.js |
21.59 KB | — | -21.59 KB (-100.0%) |
assets/client-Dq0Q6MAq.js |
— | 21.59 KB | +21.59 KB |
assets/Combination-DdLOmvYU.js |
16.12 KB | — | -16.12 KB (-100.0%) |
assets/Combination-CHXR84A0.js |
— | 16.12 KB | +16.12 KB |
assets/ThemeToggle-ZtCCfTq-.js |
13.64 KB | — | -13.64 KB (-100.0%) |
assets/ThemeToggle-DDz9c6ru.js |
— | 13.64 KB | +13.64 KB |
assets/dist-CK29K0_0.js |
10.20 KB | — | -10.20 KB (-100.0%) |
assets/dist-B8-MMbUy.js |
— | 10.20 KB | +10.20 KB |
assets/Layout-CN-724jv.js |
10.14 KB | — | -10.14 KB (-100.0%) |
assets/Layout-CUfyk3qZ.js |
— | 10.14 KB | +10.14 KB |
assets/compat-BidiPOjp.js |
10.12 KB | — | -10.12 KB (-100.0%) |
assets/compat-BOvxfbHG.js |
— | 10.12 KB | +10.12 KB |
assets/Tooltip-C2M2o9hk.js |
7.93 KB | — | -7.93 KB (-100.0%) |
assets/Tooltip-CCL7e45H.js |
— | 7.93 KB | +7.93 KB |
assets/dist-DqDvsSlc.js |
6.99 KB | — | -6.99 KB (-100.0%) |
assets/dist-vvnfrFEG.js |
— | 6.99 KB | +6.99 KB |
assets/jsx-runtime-D2-vQAkS.js |
5.67 KB | — | -5.67 KB (-100.0%) |
assets/jsx-runtime-Suavd6wv.js |
— | 5.67 KB | +5.67 KB |
assets/dist-BXWGsdq5.js |
3.94 KB | — | -3.94 KB (-100.0%) |
assets/dist-CW18yqev.js |
— | 3.94 KB | +3.94 KB |
assets/CodeTabs-CibKMLFc.js |
3.89 KB | — | -3.89 KB (-100.0%) |
assets/CodeTabs-Bddfa2sD.js |
— | 3.89 KB | +3.89 KB |
assets/CodeBox-DPh2JTJn.js |
3.44 KB | — | -3.44 KB (-100.0%) |
assets/CodeBox-nTFnhk5t.js |
— | 3.44 KB | +3.44 KB |
assets/hooks.module-CamFfzz1.js |
3.40 KB | — | -3.40 KB (-100.0%) |
assets/hooks.module-s9wfDDNr.js |
— | 3.40 KB | +3.40 KB |
assets/FunctionSignature-CpjW9Kse.js |
2.28 KB | — | -2.28 KB (-100.0%) |
assets/FunctionSignature-BEojS7IQ.js |
— | 2.28 KB | +2.28 KB |
assets/Banner-Bq6DJTEX.js |
2.19 KB | — | -2.19 KB (-100.0%) |
assets/Banner-DlFTTX0X.js |
— | 2.19 KB | +2.19 KB |
assets/ChangeHistory-n7sQS4Vy.js |
1.77 KB | — | -1.77 KB (-100.0%) |
assets/ChangeHistory-BX3eIUtk.js |
— | 1.77 KB | +1.77 KB |
assets/DataTag-BZCfQQtz.js |
844.00 B | — | -844.00 B (-100.0%) |
assets/DataTag-C8_euUlY.js |
— | 844.00 B | +844.00 B |
assets/DocumentationIndex-axKKpb-8.js |
833.00 B | — | -833.00 B (-100.0%) |
assets/DocumentationIndex-DwduBlD_.js |
— | 833.00 B | +833.00 B |
assets/ArrowUpRightIcon-DuQb37F_.js |
618.00 B | — | -618.00 B (-100.0%) |
assets/ArrowUpRightIcon-BbHDY9iR.js |
— | 618.00 B | +618.00 B |
assets/Badge-B85_1cOt.js |
607.00 B | — | -607.00 B (-100.0%) |
assets/Badge-Dox463y7.js |
— | 607.00 B | +607.00 B |
assets/AlertBox-CjB-YooR.js |
591.00 B | — | -591.00 B (-100.0%) |
assets/AlertBox-8KlJ1j1V.js |
— | 591.00 B | +591.00 B |
assets/CodeBracketIcon-Dvb-JilH.js |
512.00 B | — | -512.00 B (-100.0%) |
assets/CodeBracketIcon-YqUexKPH.js |
— | 512.00 B | +512.00 B |
assets/dist-KTKwpwvA.js |
477.00 B | — | -477.00 B (-100.0%) |
assets/dist-Bxf_F6I7.js |
— | 477.00 B | +477.00 B |
assets/ChevronDownIcon-CIlTAhga.js |
468.00 B | — | -468.00 B (-100.0%) |
assets/ChevronDownIcon-H-5RUINM.js |
— | 468.00 B | +468.00 B |
assets/Blockquote-B3PQ_AxW.js |
167.00 B | — | -167.00 B (-100.0%) |
assets/Blockquote-BQu1Urbw.js |
— | 167.00 B | +167.00 B |
assets/withIsland-Bq2J4i7S.js |
105.00 B | — | -105.00 B (-100.0%) |
assets/withIsland-EGolLQug.js |
— | 105.00 B | +105.00 B |
Performance estimate (single CI run)
- Generation time: 4.3% slower (62.00 s → 64.66 s)
- Peak memory: 10.3% higher (3.21 GB → 3.54 GB)
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Member
Author
|
Bump @nodejs/web for reviews |
Member
|
@avivkeller reviews on this will take a bit of time, this PR touchjes 68 files, it is... expected for this to... be complex to review 🙇 |
Member
Author
|
Bump! |
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
reviewed
Sep 19, 2026
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
Looking really good. Left a few comments, I left out more specific nits, to let this move forward. If you could address my current comments I believe I'm good with a ✔️
Member
|
Can you also rebase, @avivkeller? |
Co-Authored-By: flakey5 <73616808+flakey5@users.noreply.github.com> Signed-off-by: avivkeller <me@aviv.sh>
avivkeller
force-pushed
the
json-generators
branch
from
September 21, 2026 14:25
7df595e to
a00a55a
Compare
ovflowd
approved these changes
Sep 21, 2026
ovflowd
left a comment
ovflowd
left a comment
Member
There was a problem hiding this comment.
One last comment to be addressed, feel free to merge after that. SGTM!
bmuenzenmeyer
approved these changes
Sep 22, 2026
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
Contributor
There was a problem hiding this comment.
I only wonder if we should add something to the specification or CONTRIBUTING.md to now mention that the schema version spans multiple location
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to supersede #287 and fix #214.
The majority of the added lines are test fixtures and schemas, so do not be alarmed by the size of this PR.
This new generator writes one JSON document per source file. Each document
is a tree of the file's headings, in document order, with the metadata,
signature or type, Markdown body, and code examples of every one of them.
The output is described by a JSON schema, published at the URL every document
carries in
$schema, and shipped with the package as@doc-kit/core/generators/json/schema.json.An output looks roughly like:
{ "$schema": "https://doc-kit.nodejs.org/schemas/api-doc/1.0.0.json", "id": "fs", "path": "/fs", "type": "module", "module": "fs", "title": "File system", "introducedIn": "v0.10.0", "sourceLink": { "path": "lib/fs.js", "url": "https://github.com/nodejs/node/blob/HEAD/lib/fs.js" }, "stability": { "index": "2","description": "Stable" }, "added": [], "deprecated": [], "removed": [], "napiVersion": [], "changes": [], "description": "The `node:fs` module enables interacting with the file system in a\nway modeled on standard POSIX functions.\n\n…", "summary": "The `node:fs` module enables interacting with the file system in a way modeled on standard POSIX functions.", "examples": [], "children": [] }