Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, the
update-package-lockjob fails the release withETARGET No matching version found for @ionic/core@^9.0.x. Since 9.0.4 npm processes publishes asynchronously, sonpm publishreturns before the version resolves. The registry recorded@ionic/core4s after the publish step on 9.0.3, but 5m11s on 9.0.4 and 5m10s on 9.0.5, against a near constant 5m04s gap from publishing to that job, so the last two releases each missed by about six seconds and needed the job re-run by hand.Separately,
purge-cdn-cachehas never done anything. A missing comma before the@nextCSS entry made the body invalid JSON, so jsDelivr rejected every purge withInvalidContentwhilecurlexited 0 and the step stayed green. That has been true since #29121.What is the new behavior?
The
Bump Package Lockstep is split intoResolve Package Locks, which retrieslerna exec "npm install --package-lock-only --prefer-online"every 15s against a 900s wall clock deadline, andCommit Package Locks, which does the commit and the push. We retry the install rather than probing withnpm viewfirst, because the two read separately cached documents and a passing probe wouldn't mean the install resolves. The--prefer-onlineflag is required because a failed install caches the version-less packument locally for 300s, so plain retries never reach the registry. The bound is wall clock rather than an attempt count since one attempt costs about 45s and a fixed count would overruntimeout-minutes.The
purge-cdn-cachejob now runs afterupdate-package-lockand gates on a newresolvedoutput rather than the job's result, so a failed lockfile push still purges but an unresolved version doesn't. The comma is fixed and the step checks the HTTP status, failing on a 4xx because a bad payload is otherwise silent, and warning on anything else so a jsDelivr outage doesn't fail a release.Does this introduce a breaking change?
Other information
The
release.ymlworkflow only runs on a real production release, so I couldn't test this end to end. I ran each step's shell against stubs for the failure paths, but the first real signal will be the next release.