Skip to content

chore(tests): add updated snapshots due to tokens diffs - #31458

Closed
BenOsodrac wants to merge 0 commit into
ROU-13047-codefrom
ROU-13047-tests
Closed

BenOsodrac wants to merge 0 commit into
ROU-13047-codefrom
ROU-13047-tests

Conversation

@BenOsodrac

Copy link
Copy Markdown
Contributor

Issue number: internal


What is the new behavior?

  • Updated snapshots due to tokens different values.
  • Adjust subtle related palletes to support AA contrast with the new token values.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Sep 18, 2026 9:58am UTC

Request Review

@BenOsodrac BenOsodrac added package: core @ionic/core package package: react @ionic/react package type: bug a confirmed bug report labels Sep 17, 2026
@BenOsodrac
BenOsodrac marked this pull request as ready for review September 17, 2026 14:18
@BenOsodrac
BenOsodrac requested a review from a team as a code owner September 17, 2026 14:18
@BenOsodrac
BenOsodrac requested review from OS-giulianasilva and brandyscarney and removed request for a team September 17, 2026 14:18
@BenOsodrac BenOsodrac closed this Sep 17, 2026
@BenOsodrac BenOsodrac reopened this Sep 17, 2026
@github-actions github-actions Bot removed the package: react @ionic/react package label Sep 17, 2026

@brandyscarney brandyscarney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did flag one screenshot for a potential regression but if it looks good to you it's good for me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging this in case it was unintentional - the selected option is no longer bold

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will double check with Design!

This branch was successfully deployed

1 active deployment
Preview 96462612 Deployed Sep 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants