Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Align the Nix toolchain mapping and devcontainer installation with the new pin, and update remaining floating nightly references.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates the pinned Rust nightly toolchain to nightly-2026-09-22 across development and CI workflows.
Changes:
- Updates nightly commands in
Justfile. - Pins the Coverage CI and devcontainer toolchains.
- Reformats guest error imports.
| File | Summary | Review findings |
|---|---|---|
src/hyperlight_guest/src/error.rs |
Applies import formatting changes. | — |
Justfile |
Updates nightly toolchain usage. | Critical (2 votes): flake.nix is not aligned with the new pin. Nit (1 vote): floating nightly references remain in user documentation and configuration. |
.github/workflows/Coverage.yml |
Installs the pinned coverage toolchain. | — |
.devcontainer/devcontainer.json |
Configures Rust Analyzer with the pinned toolchain. | Moderate (2 votes): the image does not install the requested dated toolchain. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
added
kind/dependencies
| "settings": { | ||
| "rust-analyzer.rustfmt.extraArgs": [ | ||
| "+nightly" // required for rustfmt.toml which uses nightly features | ||
| "+nightly-2026-09-22" // required for rustfmt.toml which uses nightly features |
There was a problem hiding this comment.
does this mean we need bump this regularly? wouldn't the +nightly just get the latest?
There was a problem hiding this comment.
We can bump it as regularly as we would like. I think pinning it is a good idea for consistent results anyway
There was a problem hiding this comment.
I guess it seems like it hasn't been an issue for us in the past. I get nervous about having to remember to bump this but maybe we can drop a note somewhere in a readme/rusttoolchain.toml to remind folks
There was a problem hiding this comment.
I think next time bumping, whoever is doing the bumping will hopefully search for nightly-2026-09-22 and discover all usecases
Updates the pinned nighly toolchain version in justfile.
Also pins some previous usages of bare
+nightlyto use the specific version