fix: match allowed regex fully - #1054
Conversation
eternal-flame-AD
left a comment
There was a problem hiding this comment.
Lgtm.
Also, I think a simpler solution is simply prepend/append a ^ and $ to the regex if it's not already there.
Ad a side note, I honestly didn't understand why this is strictly needed. I agree with the original issue that it seems like WebSocket won't be a viable cross origin attack vector (does not eliminate the need to exfiltrate token).
|
I see this more as a fix to make the setting behave as expected (must match the string fully). I'd say the current docs and issues seem to imply this. I'll change it to wrap the user regex into |
d2af557 to
8f2dad9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 76.16% 76.09% -0.07%
==========================================
Files 66 67 +1
Lines 3625 3619 -6
==========================================
- Hits 2761 2754 -7
- Misses 653 654 +1
Partials 211 211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #1052