fix(integrations): remove duplicate Forge dispatch override - #4714
Merged
Merged
Conversation
Keep the equivalent, documented Forge override and remove the shadowing definition introduced by overlapping fixes. Ruff F811 then passes without changing dispatch behavior. Assisted-by: GitHub Copilot (model: GPT-6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
The focused cleanup preserves tested Forge dispatch behavior and resolves the duplicate-definition lint error.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the duplicate Forge execution-argument method, resolving Ruff F811 without changing dispatch behavior.
Changes:
- Retains the documented
build_exec_argsimplementation. - Removes the behaviorally identical duplicate definition.
| File | Description |
|---|---|
src/鈥媠pecify_cli/鈥媔ntegrations/鈥媐orge/鈥媉_init__.py |
Removes the duplicate method implementation. |
馃挕 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the second
ForgeIntegration.build_exec_argsdefinition introduced when overlapping Forge dispatch fixes were merged. Both implementations produce the same CLI arguments, so keeping the documented first definition resolves Ruff F811 without changing behavior.Testing
uv run specify --helpuv sync --extra test && .venv/bin/python -m pytest(8,520 passed, 17 skipped)uvx ruff@0.15.0 check src tests(passed)AI Disclosure
AI disclosure: GitHub Copilot (model: GPT-6 Sol; session-default reasoning effort, not explicitly set; autonomous) authored the code cleanup, ran Ruff and the full test suite, and drafted this PR on behalf of @mnriem. The change has not been line-by-line human-reviewed.