fix: log rollback errors instead of silently swallowing them - #3926
Quratulain-bilal wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds debug diagnostics for failed best-effort bundle rollbacks.
Changes:
- Imports Python logging.
- Logs exceptions raised while removing rollback components.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/bundler/services/installer.py |
Adds rollback failure logging. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Please address Copilot feedback
_rollback() caught and discarded all exceptions during component removal. If a rollback step fails, the user has no indication the rollback was incomplete. Now logs failures at debug level with exc_info=True. Also fixed format string bug: exc_info=True was passed as positional arg to logger.debug() causing TypeError. Adds regression test for rollback error logging. Closes github#3926
|
The logging-format issue from the earlier review is corrected. This adds debug-only diagnostics rather than normal user-facing reporting of an incomplete rollback, so we’re keeping it as Before further review, resolve the conflicts with current Drafted for @mnriem with assistance from GitHub Copilot (model: GPT-6 Astra; interactive comment drafting). |
mnriem
added
triage-can-wait
|
Please resolve conflicts. Probably needs a rebase |
3af87bc to
dc7bf2b
Compare
|
|
||
| from . import BundlerError | ||
|
|
||
| logger = logging.getLogger(__name__) |
|
Please address Copilot feedback and fix test & lint errors |
Problem
_rollback()caught and discarded all exceptions during component removal. If a rollback step fails, the user has no indication the rollback was incomplete.Fix
Add debug logging so failures are visible.