fix(rust): serve session requests sent during session.create - #2747
Open
costajohnt wants to merge 1 commit into
Open
costajohnt wants to merge 1 commit into
costajohnt wants to merge 1 commit into
Conversation
Start the session event loop before the session.create RPC when the session id is known up front, as resume already does, so a sessionFs.readFile issued while the create is in flight is answered instead of queued forever. Fixes github#2624
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a session fs provider,
create_sessionhangs: the CLI sendssessionFs.readFilewhilesession.createis still in flight, but the session's request channel is only drained by the event loop, which the create path started after the RPC returned. The session was already registered before the RPC, so the request was queued and never answered.This starts the event loop before the RPC whenever the session id is known up front, which is what
resume_sessionalready does. Cloud sessions with a server-assigned id still start it after the response registers the session.Added
session_fs_serves_requests_during_create, which sendssessionFs.readFilebefore answeringsession.create. It times out on main and passes with this change. Thesession::,session_lifecycle::andsession_config::e2e groups pass.Two things I left matching resume rather than changing: a
capabilities.changedreceived during create is overwritten by the create result, and explicit error paths stop the early loop through the registration guard's drop instead of awaiting it.Fixes #2624