Skip to content

Fix typos and two dead Nokogiri links - #2741

Merged
simon04 merged 1 commit into
freeCodeCamp:mainfrom
olitreadwell:chore/fix-typos-and-broken-link
Sep 23, 2026
Merged

simon04 merged 1 commit into
freeCodeCamp:mainfrom
olitreadwell:chore/fix-typos-and-broken-link

Conversation

@olitreadwell

Copy link
Copy Markdown
Contributor

What changed

Nine fixes across eight files. I checked every line against main before opening this, and each one is still wrong there.

Typos:

  • .github/ISSUE_TEMPLATE/documentation_bug.md: "miss-formatted" to "mis-formatted"
  • docs/maintainers.md: "is as follow:" to "is as follows:"
  • docs/filter-reference.md: "links that can't reached from anywhere else" to "can't be reached"
  • lib/docs/filters/eslint/entries.rb: "mispelled" to "misspelled" (comment)
  • lib/docs/filters/pandas/clean_html.rb: "clases" to "classes" (comment)
  • lib/docs/filters/redis/entries.rb: "Core: Server managment" to "Core: Server management"
  • lib/tasks/updates.thor: "outdated than v8 is aswell" to "is as well" (comment)

Dead links, three references in two files:

Old Status New Status
http://www.rubydoc.info/github/sparklemotion/nokogiri/Nokogiri/XML/Node 404 https://nokogiri.org/rdoc/Nokogiri/XML/Node.html 200
http://nokogiri.org/Nokogiri/XML/Node.html 404 https://nokogiri.org/rdoc/Nokogiri/XML/Node.html 200

Notes

  • The redis line changes a user-visible category label. I searched the repo for other occurrences of "Server managment" and that line is the only one.
  • No Ruby logic changed: two comments, one label string, one comment in a Thor task. ruby -c passes on all four Ruby files.
  • The branch is rebased onto main at the time of opening, and the diff is 10 lines in, 10 lines out.

Disclosure

Drafted with AI assistance. I found the typos, checked each link's status and each line against current main myself, and reviewed the diff line by line.

@olitreadwell
olitreadwell requested a review from a team as a code owner September 23, 2026 09:18
@simon04
simon04 requested a balanced review from Copilot September 23, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The lib/tasks/updates.thor comment still needs grammatical rephrasing.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)

Comment thread lib/tasks/updates.thor
def check(*names)
# Convert names to a list of Scraper instances
# Versions are omitted, if v10 is outdated than v8 is aswell
# Versions are omitted, if v10 is outdated than v8 is as well
@simon04
simon04 merged commit fde566c into freeCodeCamp:main Sep 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants