fix(hub): retry temp-dir cleanup on Windows to avoid EPERM - #408
Merged
Merged
Conversation
◈ PR LensNote Only tests changed, so PR Lens left this pull request undrawn. Comment
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
windows-latest, node 26unit-test job fails intermittently inpackages/hub/src/node/__tests__/host-terminals.test.ts:The Windows-only child-process-tree tests kill the shimmed process and then immediately remove its temp dir. Windows releases the killed process's file handles asynchronously, so the
rmcan race the OS and hitEPERMbefore the handles are gone.What
Give the cleanup
rmSynca bounded retry (maxRetries: 10,retryDelay: 100). Node retries specifically onEPERM/EBUSY/etc. for recursive removals, which lets the handles drain instead of failing the run.This changes test cleanup only; no runtime behaviour changes.
This PR was created with the help of an agent.