Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining SDCC examples in Trac 6028.
@dptroperands currently cause a syntax error, and#(s_XINIT >> 8)is altered during preprocessing before the late assembler simplifier runs, leaving an unmatched).Normalize complete literal
__asm/__endasmregions in the raw preprocessor tokens, including newly loaded headers. Preserve an opaqueasm()analysis barrier, exactly one terminator and the locations of surrounding C code. Leave ambiguous/missing/nested regions, real preprocessing directives, macro definitions and other assembler dialects on the existing path. The existing pragma-asm handling is unchanged.Add seven preprocessor test methods covering operands, empty/adjacent blocks, comments, missing/nested markers, other dialects, configurations and unbraced control flow. Two CLI regressions cover the main-file and included-header paths and verify that a real division-by-zero diagnostic after the block remains at its original line.
Validation:
@and#(failures; 18 original/patched CLI comparisons pass, including outside-C diagnostic and GNU/MS/macro controls.git diff --checkpass.One earlier Windows full-suite attempt exited with
0xc0000005while displayingTestType::checkTooBigShift_Unix32; the full rerun above passed. The recorded fault offset resolves to the unchangedToken::Match. A bounded debugger run did not reproduce that failure but was stopped after becoming slow inTestValueFlow::valueFlowHang; its outcome is inconclusive. No root cause or baseline attribution is claimed.This is a bounded fix for the demonstrated literal marker-delimited blocks. It does not repair initial lexer errors, macro-generated markers, or ARM assembler-function syntax.
Please assign Trac 6028 to KiritoYG for this patch and confirm whether this remaining-defect fix qualifies under the published USD 10 bounty bracket. After qualifying closure, I can use the documented bounty-request process; please also confirm the available settlement channel.