Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuration discovery considers an optional macro without a required platform macro, an active
#errorcan skip that configuration.--check-configcurrently gives no explanation, making the resulting unused-function warning difficult to diagnose. This addresses the requested diagnostic in Trac #6672 comment 5.Report a suppressible
invalidConfigurationinformation message in--check-configfor the#errorfailures otherwise hidden by existing error handling. Include the configuration's user/automatic defines, the original error text, and source/header location. Preserve the existing error for explicit defines without--force, avoiding a duplicate message. Normal analysis and configuration enumeration remain unchanged; this does not automatically infer the required macro or remove the ordinary unused-function diagnostic.Validation on Windows with Clang 22.1.8 and CMake/Ninja:
redundantCopyLocalConstin upstream self-check. That diagnostic was reproduced with the original analyzer and is now absent on the changed test file; all 24TestCppchecktests pass after rebuilding, and Uncrustify 0.80.1 matches. The full-suite/CLI results above cover the unchanged production implementation; upstream checks for the updated head are pending.git diff --checkpasses. Local build used Debug with PCH disabled and serial compilation after Clang crashed on unchanged code in Release/parallel builds. GUI and non-Windows CI were not run locally.Please assign this work to KiritoYG if needed. I would like this diagnostic fix considered under the published $10 bounty schedule, subject to acceptance and the required ticket closure. Please confirm its eligibility and the supported settlement route; GitHub Sponsors is available if accepted. No award or payment is being claimed.