deps: bump golang.org/x/text to v0.41.0 - #168
Conversation
Bumps the indirect dependency golang.org/x/text from v0.32.0 to v0.41.0 to satisfy the requirement of >= v0.39.0. v0.41.0 is the highest release that still requires only go 1.25, matching this module's current go directive. v0.42.0 was intentionally avoided because it raises its minimum to go 1.26.0, which would force the same bump on this module and on every downstream consumer of cockroachdb/errors. x/text is a transitive dependency only (pulled in via golang.org/x/net and grpc); no package in this module imports it directly, so there are no API changes to accommodate. `go build`, `go vet`, and the full test suite pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
|
From Claude for sanity check: Verdict: safe to approve. The bump exists to pick up a security fix, and nothing in it adds risk to CockroachDB. The cockroach repo already pins x/text v0.41.0 on master and release-26.4, so merging this PR changes nothing in the cockroach binary. Go always resolves to the highest version any module asks for, and that is already v0.41.0. Sources: What in the bump touches CockroachDBWhy the bump exists. Go advisory GO-2026-5970, also CVE-2026-56852, fixed in v0.39.0. In plain terms: the I fed the upstream reproducer input to every entry point cockroach could reach, under four versions:
Only the iterator hangs. CockroachDB calls norm in two places, identifier normalization in
Other cockroach-facing packages, all verified unchanged in behavior:
Full list of upstream changes from v0.32.0 to v0.41.0Twenty-one commits, grouped by release:
PR hygiene checks
|
|
TFTR! |
Bumps the indirect dependency golang.org/x/text from v0.32.0 to v0.41.0 to satisfy the requirement of >= v0.39.0.
v0.41.0 is the highest release that still requires only go 1.25, matching this module's current go directive. v0.42.0 was intentionally avoided because it raises its minimum to go 1.26.0, which would force the same bump on this module and on every downstream consumer of cockroachdb/errors.
x/text is a transitive dependency only (pulled in via golang.org/x/net and grpc); no package in this module imports it directly, so there are no API changes to accommodate.
go build,go vet, and the full test suite pass.This change is