Skip to content

fix: Do not use crawlee version 1.10.1 - #1136

Merged
Pijukatel merged 2 commits into
masterfrom
do-not-use-crawlee-1-10-1
Sep 22, 2026
Merged

Pijukatel merged 2 commits into
masterfrom
do-not-use-crawlee-1-10-1

Conversation

@Pijukatel

@Pijukatel Pijukatel commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

It made backwards-incompatible changes to crawlee._utils.try_import

Unreleased version of Crawlee 1.10.2 should include backwards compatible fix apify/crawlee-python#2247

It made backwards incompatible changes to `crawlee._utils.try_import`
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Sep 22, 2026
@apify-service-account apify-service-account added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 22, 2026
@Pijukatel
Pijukatel requested a review from janbuchar September 22, 2026 08:16
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (9aade20) to head (0f73f2a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files          53       53           
  Lines        3519     3519           
=======================================
  Hits         3264     3264           
  Misses        255      255           
Flag Coverage Δ
e2e 32.73% <ø> (?)
integration 53.33% <ø> (ø)
unit 89.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread tests/e2e/actor_source_base/requirements.txt Outdated
Remove specific version of crawlee from requirements.
@Pijukatel
Pijukatel requested a review from janbuchar September 22, 2026 08:44
@Pijukatel Pijukatel added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 22, 2026
@Pijukatel
Pijukatel merged commit 19c3cba into master Sep 22, 2026
31 of 34 checks passed
@Pijukatel
Pijukatel deleted the do-not-use-crawlee-1-10-1 branch September 22, 2026 09:21
@vdusek

vdusek commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Whoops, thanks, and sorry @Pijukatel.

This is the part that isn't tested and is quite difficult to test. We'd need multiple test environments with different combinations of extras installed.

Maybe I should look into that, since this is my fuck up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants