Skip to content

chore: Use test_util feature to hide internal public APIs - #25678

Closed
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:internal-public-test
Closed

chore: Use test_util feature to hide internal public APIs#25678
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:internal-public-test

Conversation

@2010YOUY01

@2010YOUY01 2010YOUY01 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

Follow-up for #25495

See PR diff in api_health.md for rationale

What changes are included in this PR?

  1. Document the convention for internal public APIs for test purpose (#[doc(hidden)] and test_util feature)
  2. Enforce it for existing occurence.

What is the testing strategy for this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate catalog Related to the catalog crate common Related to common crate proto Related to proto crate functions Changes to functions implementation datasource Changes to the datasource crate ffi Changes to the ffi crate physical-plan Changes to the physical-plan crate spark labels Sep 24, 2026
2010YOUY01
2010YOUY01 commented Sep 24, 2026
View reviewed changes
Comment thread docs/source/contributor-guide/api-health.md
2. Internal utilities, such as operator APIs required by the optimizer to inspect
or rewrite execution plans across crate boundaries.

Note: Exposing internal APIs for tests or microbenchmarks is not recommended,

@2010YOUY01 2010YOUY01 Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat subjective, I think it's not a good idea to test or benchmark against implementation details overall. I'm not so sure if there are any special cases that require this pattern.

@2010YOUY01
2010YOUY01 marked this pull request as draft September 24, 2026 02:34
@codecov-commenter

codecov-commenter commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.49%. Comparing base (ebdb657) to head (c538043).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25678      +/-   ##
==========================================
+ Coverage   82.45%   82.49%   +0.04%     
==========================================
  Files        1140     1140              
  Lines      436434   437763    +1329     
  Branches   436434   437763    +1329     
==========================================
+ Hits       359840   361124    +1284     
- Misses      54840    54842       +2     
- Partials    21754    21797      +43

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details 
     Cloning apache/main
    Building datafusion v55.1.0 (current)
       Built [  54.739s] (current)
     Parsing datafusion v55.1.0 (current)
      Parsed [   0.033s] (current)
    Building datafusion v55.1.0 (baseline)
       Built [  54.092s] (baseline)
     Parsing datafusion v55.1.0 (baseline)
      Parsed [   0.034s] (baseline)
    Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.812s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function local_unpartitioned_file in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/object_store.rs:66
  function test_table_with_cache_factory in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:372
  function create_table_dual in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:65
  function ensure_head_concurrency in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/object_store.rs:79
  function partitioned_file_groups in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:116
  function columns in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:215
  function bounded_stream in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:279
  function scan_empty_with_partitions in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:80
  function table_with_decimal in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:247
  function test_table_with_name in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:132
  function populate_csv_partitions in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:153
  function scan_partitioned_csv in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:83
  function assert_fields_eq in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:204
  function register_unbounded_file_with_ordering in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:262
  function make_partition in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:235
  function register_aggregate_csv in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:116
  function plan_and_collect in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:145
  function make_test_store_and_state in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/object_store.rs:48
  function scan_empty in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:68
  function table_with_sequence in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/mod.rs:221
  function aggr_test_schema in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:93
  function test_table in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:139
  function register_test_store in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/object_store.rs:42

--- failure struct_now_doc_hidden: pub struct is now #[doc(hidden)] ---

Description:
A pub struct is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_now_doc_hidden.ron

Failed in:
  struct TestCsvFile in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/csv.rs:30
  struct TestParquetFile in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/parquet.rs:49
  struct SystemVar in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/variable.rs:27
  struct UserDefinedVar in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test/variable.rs:50
  struct ParquetScanOptions in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/parquet.rs:58
  struct TestTableFactory in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:183
  struct TestTableProvider in file /home/runner/work/datafusion/datafusion/datafusion/core/src/test_util/mod.rs:231

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [ 112.384s] datafusion
    Building datafusion-catalog v55.1.0 (current)
       Built [  38.077s] (current)
     Parsing datafusion-catalog v55.1.0 (current)
      Parsed [   0.024s] (current)
    Building datafusion-catalog v55.1.0 (baseline)
       Built [  37.865s] (baseline)
     Parsing datafusion-catalog v55.1.0 (baseline)
      Parsed [   0.024s] (baseline)
    Checking datafusion-catalog v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.152s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure struct_pub_field_now_doc_hidden: pub struct field is now #[doc(hidden)] ---

Description:
A pub field of a pub struct is now marked #[doc(hidden)] and is no longer part of the public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_now_doc_hidden.ron

Failed in:
  field MemTable.batches in file /home/runner/work/datafusion/datafusion/datafusion/catalog/src/memory/table.rs:72
  field MemTable.batches in file /home/runner/work/datafusion/datafusion/datafusion/catalog/src/memory/table.rs:72

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  77.539s] datafusion-catalog
    Building datafusion-cli v55.1.0 (current)
       Built [  87.087s] (current)
     Parsing datafusion-cli v55.1.0 (current)
      Parsed [   0.033s] (current)
    Building datafusion-cli v55.1.0 (baseline)
       Built [  87.282s] (baseline)
     Parsing datafusion-cli v55.1.0 (baseline)
      Parsed [   0.034s] (baseline)
    Checking datafusion-cli v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.166s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 177.405s] datafusion-cli
    Building datafusion-common v55.1.0 (current)
       Built [  30.493s] (current)
     Parsing datafusion-common v55.1.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-common v55.1.0 (baseline)
       Built [  30.441s] (baseline)
     Parsing datafusion-common v55.1.0 (baseline)
      Parsed [   0.062s] (baseline)
    Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.960s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function batches_to_sort_string in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:104
  function parquet_test_data in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:284
  function format_batches in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:31
  function datafusion_test_data in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:240
  function get_data_dir in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:307
  function batches_to_string in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:98
  function arrow_test_data in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:261

--- failure macro_now_doc_hidden: macro is now #[doc(hidden)] ---

Description:
A `macro_rules!` declarative macro that was previously part of the public API is now `#[doc(hidden)]` and not public API anymore.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/macro_now_doc_hidden.ron

Failed in:
  macro assert_batches_sorted_eq in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:135
  macro create_array in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:357
  macro assert_contains in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:184
  macro assert_batches_eq in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:79
  macro assert_not_contains in /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:214

--- failure trait_now_doc_hidden: pub trait is now #[doc(hidden)] ---

Description:
A pub trait is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_now_doc_hidden.ron

Failed in:
  trait IntoArrayRef in file /home/runner/work/datafusion/datafusion/datafusion/common/src/test_util.rs:27

     Summary semver requires new major version: 3 major and 0 minor checks failed
    Finished [  64.324s] datafusion-common
    Building datafusion-datasource v55.1.0 (current)
       Built [  40.193s] (current)
     Parsing datafusion-datasource v55.1.0 (current)
      Parsed [   0.030s] (current)
    Building datafusion-datasource v55.1.0 (baseline)
       Built [  40.744s] (baseline)
     Parsing datafusion-datasource v55.1.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.401s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function verify_sort_integrity in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/mod.rs:523
  function generate_test_files in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/mod.rs:464

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  83.007s] datafusion-datasource
    Building datafusion-datasource-avro v55.1.0 (current)
       Built [  42.087s] (current)
     Parsing datafusion-datasource-avro v55.1.0 (current)
      Parsed [   0.011s] (current)
    Building datafusion-datasource-avro v55.1.0 (baseline)
       Built [  42.333s] (baseline)
     Parsing datafusion-datasource-avro v55.1.0 (baseline)
      Parsed [   0.011s] (baseline)
    Checking datafusion-datasource-avro v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.093s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  86.275s] datafusion-datasource-avro
    Building datafusion-datasource-parquet v55.1.0 (current)
       Built [  46.050s] (current)
     Parsing datafusion-datasource-parquet v55.1.0 (current)
      Parsed [   0.033s] (current)
    Building datafusion-datasource-parquet v55.1.0 (baseline)
       Built [  46.555s] (baseline)
     Parsing datafusion-datasource-parquet v55.1.0 (baseline)
      Parsed [   0.038s] (baseline)
    Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.241s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  94.387s] datafusion-datasource-parquet
    Building datafusion-expr v55.1.0 (current)
       Built [  26.764s] (current)
     Parsing datafusion-expr v55.1.0 (current)
      Parsed [   0.075s] (current)
    Building datafusion-expr v55.1.0 (baseline)
       Built [  26.295s] (baseline)
     Parsing datafusion-expr v55.1.0 (baseline)
      Parsed [   0.076s] (baseline)
    Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   1.805s] 223 checks: 221 pass, 2 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function count_udaf in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:68
  function avg in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:83
  function sum_udaf in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:55
  function count in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:70
  function max_udaf in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:361
  function min_udaf in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:283
  function sum in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:57
  function avg_udaf in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:81
  function max in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:363
  function min in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:285

--- failure struct_now_doc_hidden: pub struct is now #[doc(hidden)] ---

Description:
A pub struct is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_now_doc_hidden.ron

Failed in:
  struct Avg in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:441
  struct Count in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:213
  struct Sum in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:96
  struct Min in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:298
  struct Max in file /home/runner/work/datafusion/datafusion/datafusion/expr/src/test/function_stub.rs:376

     Summary semver requires new major version: 2 major and 0 minor checks failed
    Finished [  57.147s] datafusion-expr
    Building datafusion-expr-common v55.1.0 (current)
       Built [  18.092s] (current)
     Parsing datafusion-expr-common v55.1.0 (current)
      Parsed [   0.019s] (current)
    Building datafusion-expr-common v55.1.0 (baseline)
       Built [  18.172s] (baseline)
     Parsing datafusion-expr-common v55.1.0 (baseline)
      Parsed [   0.019s] (baseline)
    Checking datafusion-expr-common v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.310s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  37.797s] datafusion-expr-common
    Building datafusion-ffi v55.1.0 (current)
       Built [  53.011s] (current)
     Parsing datafusion-ffi v55.1.0 (current)
      Parsed [   0.061s] (current)
    Building datafusion-ffi v55.1.0 (baseline)
       Built [  52.938s] (baseline)
     Parsing datafusion-ffi v55.1.0 (baseline)
      Parsed [   0.063s] (baseline)
    Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.331s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 108.088s] datafusion-ffi
    Building datafusion-functions v55.1.0 (current)
       Built [  29.061s] (current)
     Parsing datafusion-functions v55.1.0 (current)
      Parsed [   0.081s] (current)
    Building datafusion-functions v55.1.0 (baseline)
       Built [  29.281s] (baseline)
     Parsing datafusion-functions v55.1.0 (baseline)
      Parsed [   0.083s] (baseline)
    Checking datafusion-functions v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.521s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  60.586s] datafusion-functions
    Building datafusion-functions-aggregate v55.1.0 (current)
       Built [  29.839s] (current)
     Parsing datafusion-functions-aggregate v55.1.0 (current)
      Parsed [   0.044s] (current)
    Building datafusion-functions-aggregate v55.1.0 (baseline)
       Built [  30.032s] (baseline)
     Parsing datafusion-functions-aggregate v55.1.0 (baseline)
      Parsed [   0.045s] (baseline)
    Checking datafusion-functions-aggregate v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.248s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  61.587s] datafusion-functions-aggregate
    Building datafusion-functions-aggregate-common v55.1.0 (current)
       Built [  19.686s] (current)
     Parsing datafusion-functions-aggregate-common v55.1.0 (current)
      Parsed [   0.019s] (current)
    Building datafusion-functions-aggregate-common v55.1.0 (baseline)
       Built [  19.686s] (baseline)
     Parsing datafusion-functions-aggregate-common v55.1.0 (baseline)
      Parsed [   0.019s] (baseline)
    Checking datafusion-functions-aggregate-common v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.182s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure inherent_method_now_doc_hidden: inherent method #[doc(hidden)] added ---

Description:
A method or associated fn is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_now_doc_hidden.ron

Failed in:
  TDigest::merge_unsorted_f64 in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/26e63c1b128ae3095e519d2ecfe48c194270a33b/datafusion/functions-aggregate-common/src/tdigest.rs:210

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  40.623s] datafusion-functions-aggregate-common
    Building datafusion-functions-nested v55.1.0 (current)
       Built [  32.915s] (current)
     Parsing datafusion-functions-nested v55.1.0 (current)
      Parsed [   0.038s] (current)
    Building datafusion-functions-nested v55.1.0 (baseline)
       Built [  33.225s] (baseline)
     Parsing datafusion-functions-nested v55.1.0 (baseline)
      Parsed [   0.039s] (baseline)
    Checking datafusion-functions-nested v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.277s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  68.065s] datafusion-functions-nested
    Building datafusion-optimizer v55.1.0 (current)
       Built [  25.448s] (current)
     Parsing datafusion-optimizer v55.1.0 (current)
      Parsed [   0.031s] (current)
    Building datafusion-optimizer v55.1.0 (baseline)
       Built [  25.561s] (baseline)
     Parsing datafusion-optimizer v55.1.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion-optimizer v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.241s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  52.749s] datafusion-optimizer
    Building datafusion-physical-expr v55.1.0 (current)
       Built [  27.571s] (current)
     Parsing datafusion-physical-expr v55.1.0 (current)
      Parsed [   0.047s] (current)
    Building datafusion-physical-expr v55.1.0 (baseline)
       Built [  27.342s] (baseline)
     Parsing datafusion-physical-expr v55.1.0 (baseline)
      Parsed [   0.049s] (baseline)
    Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.488s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function gen_conjunctive_numerical_expr in file /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/intervals/test_utils.rs:32
  function gen_conjunctive_temporal_expr in file /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/intervals/test_utils.rs:68

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  57.127s] datafusion-physical-expr
    Building datafusion-physical-expr-adapter v55.1.0 (current)
       Built [  30.519s] (current)
     Parsing datafusion-physical-expr-adapter v55.1.0 (current)
      Parsed [   0.010s] (current)
    Building datafusion-physical-expr-adapter v55.1.0 (baseline)
       Built [  31.002s] (baseline)
     Parsing datafusion-physical-expr-adapter v55.1.0 (baseline)
      Parsed [   0.010s] (baseline)
    Checking datafusion-physical-expr-adapter v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.108s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  63.008s] datafusion-physical-expr-adapter
    Building datafusion-physical-optimizer v55.1.0 (current)
       Built [  38.748s] (current)
     Parsing datafusion-physical-optimizer v55.1.0 (current)
      Parsed [   0.022s] (current)
    Building datafusion-physical-optimizer v55.1.0 (baseline)
       Built [  38.585s] (baseline)
     Parsing datafusion-physical-optimizer v55.1.0 (baseline)
      Parsed [   0.022s] (baseline)
    Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.151s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  79.624s] datafusion-physical-optimizer
    Building datafusion-physical-plan v55.1.0 (current)
       Built [  35.526s] (current)
     Parsing datafusion-physical-plan v55.1.0 (current)
      Parsed [   0.165s] (current)
    Building datafusion-physical-plan v55.1.0 (baseline)
       Built [  36.144s] (baseline)
     Parsing datafusion-physical-plan v55.1.0 (baseline)
      Parsed [   0.166s] (baseline)
    Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.963s] 223 checks: 219 pass, 4 fail, 0 warn, 31 skip

--- failure function_now_doc_hidden: pub function is now #[doc(hidden)] ---

Description:
A pub function is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/function_now_doc_hidden.ron

Failed in:
  function assert_strong_count_converges_to_zero in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:911
  function build_table_scan_i32 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:448
  function mem_exec_utf8 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:504
  function build_table_i32_two_cols in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:428
  function mem_exec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:495
  function contain_hashes in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:486
  function build_table_i32 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:405
  function scan_partitioned_utf8 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:490
  function get_matched_indices_with_limit_offset in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:389
  function aggr_test_schema in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:382
  function scan_partitioned in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:486
  function get_matched_indices in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:340
  function assert_is_pending in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:373
  function make_partition_utf8 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:470
  function update_from_iter in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:307
  function make_partition in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:459

--- failure struct_now_doc_hidden: pub struct is now #[doc(hidden)] ---

Description:
A pub struct is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_now_doc_hidden.ron

Failed in:
  struct BlockingStream in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:883
  struct JoinHashMapU32 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:144
  struct HashTableLookupExpr in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:278
  struct MockExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:122
  struct ErrorExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:553
  struct BlockingExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:772
  struct TestMemoryExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:65
  struct JoinHashMapU64 in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:224
  struct TestPartitionStream in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test.rs:517
  struct BarrierExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:326
  struct StatisticsExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:655
  struct PanicExec in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:928
  struct TestStream in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:69
  struct BatchIndex in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/test/exec.rs:49

--- failure trait_newly_sealed: pub trait became sealed ---

Description:
A publicly-visible trait became sealed, so downstream crates are no longer able to implement it
        ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_newly_sealed.ron

Failed in:
  trait datafusion_physical_plan::joins::utils::JoinHashMapType in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:105

--- failure trait_now_doc_hidden: pub trait is now #[doc(hidden)] ---

Description:
A pub trait is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_now_doc_hidden.ron

Failed in:
  trait JoinHashMapType in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:105

     Summary semver requires new major version: 4 major and 0 minor checks failed
    Finished [  74.579s] datafusion-physical-plan
    Building datafusion-proto v55.1.0 (current)
       Built [  51.897s] (current)
     Parsing datafusion-proto v55.1.0 (current)
      Parsed [   0.018s] (current)
    Building datafusion-proto v55.1.0 (baseline)
       Built [  52.226s] (baseline)
     Parsing datafusion-proto v55.1.0 (baseline)
      Parsed [   0.019s] (baseline)
    Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.176s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 105.939s] datafusion-proto
    Building datafusion-pruning v55.1.0 (current)
       Built [  38.162s] (current)
     Parsing datafusion-pruning v55.1.0 (current)
      Parsed [   0.016s] (current)
    Building datafusion-pruning v55.1.0 (baseline)
       Built [  37.877s] (baseline)
     Parsing datafusion-pruning v55.1.0 (baseline)
      Parsed [   0.016s] (baseline)
    Checking datafusion-pruning v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.108s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  77.531s] datafusion-pruning
    Building datafusion-spark v55.1.0 (current)
       Built [  42.310s] (current)
     Parsing datafusion-spark v55.1.0 (current)
      Parsed [   0.062s] (current)
    Building datafusion-spark v55.1.0 (baseline)
       Built [  42.950s] (baseline)
     Parsing datafusion-spark v55.1.0 (baseline)
      Parsed [   0.064s] (baseline)
    Checking datafusion-spark v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.464s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  87.403s] datafusion-spark
    Building datafusion-sql v55.1.0 (current)
       Built [  39.521s] (current)
     Parsing datafusion-sql v55.1.0 (current)
      Parsed [   0.032s] (current)
    Building datafusion-sql v55.1.0 (baseline)
       Built [  39.770s] (baseline)
     Parsing datafusion-sql v55.1.0 (baseline)
      Parsed [   0.032s] (baseline)
    Checking datafusion-sql v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.332s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  81.192s] datafusion-sql
    Building datafusion-sqllogictest v55.1.0 (current)
       Built [  93.607s] (current)
     Parsing datafusion-sqllogictest v55.1.0 (current)
      Parsed [   0.022s] (current)
    Building datafusion-sqllogictest v55.1.0 (baseline)
       Built [  93.194s] (baseline)
     Parsing datafusion-sqllogictest v55.1.0 (baseline)
      Parsed [   0.022s] (baseline)
    Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.124s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 189.905s] datafusion-sqllogictest
    Building datafusion-substrait v55.1.0 (current)
       Built [ 283.587s] (current)
     Parsing datafusion-substrait v55.1.0 (current)
      Parsed [   0.018s] (current)
    Building datafusion-substrait v55.1.0 (baseline)
       Built [ 288.058s] (baseline)
     Parsing datafusion-substrait v55.1.0 (baseline)
      Parsed [   0.018s] (baseline)
    Checking datafusion-substrait v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.286s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 574.705s] datafusion-substrait

@github-actions github-actions Bot added the auto detected api change Auto detected API change label Sep 24, 2026
@2010YOUY01 2010YOUY01 mentioned this pull request Sep 24, 2026
Open
@2010YOUY01

2010YOUY01 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

The feature approach seem hard to maintain, I'd go for [#doc(hidden)] only in #25695

@2010YOUY01 2010YOUY01 closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto detected api change Auto detected API change catalog Related to the catalog crate common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate documentation Improvements or additions to documentation ffi Changes to the ffi crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate proto Related to proto crate spark sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait Changes to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@2010YOUY01 @codecov-commenter