Add reserved-port exclusions to getFreePorts - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludePortsto the Invoke payload while keeping API version 3 and the existingdata.portsresponse.Evidence
After: deterministic tests verify exclusions, distinct ports, listener lifetime and cleanup on errors, invalid inputs, and zero-count behavior. Invoke tests cover omitted fields, duplicate exclusions, and malformed payloads.
go test ./... -count=1— passed on macOS.git diff --check origin/main...HEAD— passed.Merge Danger
Door: two-way
No persistent data changes. Direct Go callers must adopt
nodep.GetFreePorts(count, excludePorts)and passnilwhen no exclusions are needed; the JSON field remains optional.Blast Radius: API
Port selection temporarily holds TCP listeners until the batch completes. Returned ports are candidates, not reservations, and UDP availability is not checked.