Allow struct.wait expected value to be a supertype - #9139
Merged
Merged
Conversation
stevenfontanella
force-pushed
the
supertype-fix
branch
from
September 22, 2026 23:51
3860cae to
0624377
Compare
stevenfontanella
marked this pull request as ready for review
September 23, 2026 20:13
stevenfontanella
requested review from
kripken
and removed request for
a team
September 23, 2026 20:13
kripken
reviewed
Sep 23, 2026
kripken
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
reffields, theexpectedref that's passed in does not need to be a subtype of the struct's field's type. See the typing rules from the proposal, and WebAssembly/shared-everything-threads#92 which explains why. From the spec:In this case
t <: (ref null (shared eq))and it's not required thatt <: t'.Since the expected value isn't required to be a subtype of the field type, we no longer need the fixing code in TypeRefining.cpp. This matches the behavior for the expected field of atomic cmpxchg, which doesn't touch
curr->expected. Thetype-refining-gufatest was a mis-optimization before, because it caused the struct.wait to block (by changing the expected value toref.null) when it did not block in the original program.Part of #8315.