fix(partners): remove Cloudflare reserved placement - #1291
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe placement utility no longer gives reserved partners priority over other partners. The documentation no longer describes reserved placement rules, and the hosting-rotation test now includes Cloudflare. ChangesPartner Placement Ordering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Cloudflare no longer has a reserved first position in deployment and hosting lists. It now follows the same tier ordering and session rotation as other partners, as intended. The documentation and the hosting-rotation test were updated to match, and no remaining defect was found. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cloudflare no longer has exclusive placement. Remove the reserved placement rules so it follows the same tier ordering and session rotation as every other partner, including deployment buttons and mixed-category lists.
Remove the outdated placement policy and extend the hosting rotation regression test to cover Cloudflare.
Validation:
pnpm testpassed, including TypeScript, lint, and 525 unit tests (3 skipped).Summary by CodeRabbit