Skip to content

chore: fix ci and build - #2399

Merged
crutchcorn merged 1 commit into
mainfrom
fix-main
Sep 22, 2026
Merged

crutchcorn merged 1 commit into
mainfrom
fix-main

Conversation

@crutchcorn

@crutchcorn crutchcorn commented Sep 22, 2026

Copy link
Copy Markdown
Member

This PR fixes some issues with main

Summary by CodeRabbit

  • Chores

    • Updated release automation to improve compatibility with the current publishing workflow.
    • Improved release messaging and publication reporting.
  • Tests

    • Expanded validation for field-level error handling.
    • Added coverage for schema issues with optional paths and missing messages.
    • Clarified the supported error format exposed during field changes.

@crutchcorn
crutchcorn marked this pull request as ready for review September 22, 2026 04:16
@crutchcorn
crutchcorn requested a review from a team as a code owner September 22, 2026 04:16
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/form/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4e853c9e-5937-4678-8bcc-f1986c167da9

📥 Commits

Reviewing files that changed from the base of the PR and between e9965af and f6034d7.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • packages/form-core/tests/FieldApi.test-d.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now uses updated Changesets action names. Field API type tests now cover standard-schema issue paths, required messages, and the updated onChange type.

Changes

Release workflow updates

Layer / File(s) Summary
Changesets action contract
.github/workflows/release.yml
The release job uses the version-script, publish-script, commit-message, and pr-title inputs. The PR comment step reads published-packages.

Field error type tests

Layer / File(s) Summary
Standard-schema error coverage
packages/form-core/tests/FieldApi.test-d.ts
The tests cover valid issues with optional paths, reject issues without message, and expect StandardSchemaV1Issue[] | undefined for onChange.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: alemtuzlak

Merge Risk: ⚪ Minimal · up to f6034

The release workflow uses the current Changesets contract, and field error typing coverage matches the standard-schema issue requirements; the change is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the general intent but does not include the required Changes, Checklist, or Release Impact sections and provides no testing or release-impact details. Add the required template sections. Describe the workflow and type-test changes, complete the checklist, and state whether the change is CI/dev-only or requires a changeset.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies CI and build fixes, which match the workflow and type-test changes. It is broad but sufficiently related to the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 22, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f6034d7

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 35s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-22 04:20:43 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2399

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2399

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2399

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2399

@tanstack/preact-form

npm i https://pkg.pr.new/@tanstack/preact-form@2399

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2399

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2399

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2399

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2399

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2399

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2399

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2399

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2399

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2399

commit: f6034d7

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (6892ed0) to head (f6034d7).
⚠️ Report is 279 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
- Coverage   90.35%   89.78%   -0.57%     
==========================================
  Files          38       66      +28     
  Lines        1752     3232    +1480     
  Branches      444      812     +368     
==========================================
+ Hits         1583     2902    +1319     
- Misses        149      296     +147     
- Partials       20       34      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn
crutchcorn merged commit 555509c into main Sep 22, 2026
9 checks passed
@crutchcorn
crutchcorn deleted the fix-main branch September 22, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants