refactor: extract shared helpers, fix naming, split god file - #10
Merged
Merged
Conversation
Structural refactoring verified safe with Regrets regression testing. ## Changes ### Decomposition — Split god file - Split `sortingAlgorithms.js` (4 algorithms in one file) into individual files: - `bubble-sort.js` — Bubble sort algorithm - `selection-sort.js` — Selection sort algorithm - `insertion-sort.js` — Insertion sort algorithm - `sortingAlgorithms.js` now re-exports from split modules for backward compatibility ### Shared Helpers — Eliminate duplication - Created `helpers/graph-helpers.js` with `buildPathActions()` function - Previously, identical `pathActions()` was duplicated in both `graph.js` and `shortestPath.js` - Both files now import from shared helper, export as `pathActions` for backward compat - Fixed ESM import: `shortestPath.js` changed `'./graph'` → `'./graph.js'` ### Naming — Make names honest and descriptive - Fixed typo: `seive()` → `sieve()` (Sieve of Eratosthenes) with backward-compatible alias - Fixed naming convention: `convex_hull()` → `convexHull()` (camelCase in JS) with alias - Descriptive names: `cw()` → `isClockwiseTurn()`, `ccw()` → `isCounterClockwiseTurn()` with aliases ## Verification All changes verified safe with Regrets regression testing: - 15 clusters: all GREEN - 27 raw outputs: match pre-refactor KEBENARAN 1 exactly - 15 fingerprints: match pre-refactor KEBENARAN 2 - 2 chain hashes: match pre-refactor chains
Owner
|
Thanks for the PR! Looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Structural refactoring of the algorithm modules, verified safe with Regrets regression testing (15 clusters, 27 outputs, 2 chains — all GREEN).
Decomposition — Split god file
sortingAlgorithms.jscontained 4 sorting algorithms in one file. Split into:bubble-sort.js— Bubble sort onlyselection-sort.js— Selection sort onlyinsertion-sort.js— Insertion sort onlysortingAlgorithms.js— Re-exports for backward compatibilityShared Helpers — Eliminate duplication
helpers/graph-helpers.jswithbuildPathActions()functionpathActions()was duplicated in bothgraph.jsandshortestPath.jsshortestPath.jschanged./graph→./graph.jsNaming — Make names honest and descriptive
seive()→sieve()(Sieve of Eratosthenes) with backward-compatible aliasconvex_hull()→convexHull()(camelCase) with aliascw()→isClockwiseTurn(),ccw()→isCounterClockwiseTurn()with aliasesVerification Results
All changes verified safe with Regrets output-based regression testing:
Fingerprint Summary (before → after)
Chain Hash Summary (before → after)
No behavior was changed. All refactoring is structurally safe.