This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Don't specialize is_system_tag for host_system_tag when compiling for device - #1691
Open
ericniebler wants to merge 1 commit into
Open
ericniebler wants to merge 1 commit into
ericniebler wants to merge 1 commit into
Conversation
ericniebler
added
type: bug: functional
Collaborator
Author
|
run tests |
alliepiper
approved these changes
May 17, 2022
alliepiper
left a comment
alliepiper
left a comment
Contributor
There was a problem hiding this comment.
We should add a comment explaining why this specialization is disabled, but LGTM.
Contributor
|
Looks like there are some new failures that will need to be addressed before merging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.