Fixed #9160: Failed COMMIT of a DDL transaction leaves orphan RDB$FORMATS records - #9164
Merged
Merged
Conversation
hvlad
approved these changes
Sep 23, 2026
dyemanov
approved these changes
Sep 24, 2026
dyemanov
left a comment
dyemanov
left a comment
Member
There was a problem hiding this comment.
I'm not really sure whether its should be moved under IF for an extra safety or not, but failed to imagine how it could fail with the current code. Leaving it up to you.
Member
Author
IMO 'if' is needed here to avoid use of nullptr if something goes wrong (it's 0 phase!) in metadata cache. RDB$FORMATS cleanup is safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's partial fix for particular problem, it does not pretend to fix other bad cases with RDB$FORMATS.