Conversation
Rename js/__internal/core/utils/m_version.ts and m_browser.ts, updating the two public re-export shims and the six jQuery/Knockout integration imports. No content change - the rename is kept as its own commit so git and GitHub preserve the file history. The renamed files now fall under the strict eslint ruleset, so this commit alone does not lint clean; the follow-up commit fixes that. Committed with --no-verify for that reason. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
version.ts
Introduce the Version type (string | number | (string | number)[]) that
the QUnit suite and the six call sites already relied on, and move the
argument normalization out of compare() into a module-level toParts()
that returns number[].
parseInt(x[i] || 0, 10) split into two distinct cases: inside toParts
the `|| 0` is kept, because '1.'.split('.') yields an empty string that
has to read as 0 and `??` would not catch it; the out-of-range lookup
became xParts[i] ?? 0, where the only missing value is undefined.
maxLevel got an explicit undefined check so the typed signature holds,
but the finite test stays on the global isFinite. compare is
re-exported from the deprecated yet still public core/utils/version
module, where untyped JS callers may pass maxLevel as a numeric string;
Number.isFinite would reject those and silently stop capping the
comparison depth.
browser.ts
Type the detection result with BrowserName / BrowserInfo / Browser,
mirroring the shape of the public js/core/utils/browser.d.ts, which is
deliberately left untouched.
The `exec() || cond && exec() || []` chain became a `??` chain, and
`browserVersion && browserVersion[1]` became `exec(...)?.[1]`. Typing
`ua` as string also made prefer-includes fire, so indexOf(x) >= 0 is
now includes(x).
extend() is still used to build the singleton, so the undefined-valued
keys it skips keep being skipped; it is typed in its own block later.
widget.ts
devices.real().version is number[] | undefined, which the newly typed
compare() rejects. Pass `version ?? []`. The rule body only runs on
iOS, where version is always an array, so runtime behaviour is
unchanged - previously an undefined would have thrown on x.length.
Verified: eslint clean on all three files, build:ts:internal green, and
the QUnit suites utils.version.tests.js (10/10) and
utils.browser.tests.js (27/27) pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dmlvr
force-pushed
the
core-utils-improve-typing_26_1/version_browser
branch
from
September 22, 2026 08:29
8a210e1 to
bbefc61
Compare
dmlvr
changed the title
pharret31
approved these changes
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
origin: #35281