GridCore - Remove 'rowDragging.filter' option from d.ts and 'useKeyboard' from deprecated options - #35277
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The existing focus.integration.tests.js test still asserts the removed useKeyboard mapping and will fail until updated.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Removes obsolete rowDragging.filter declarations and the stale DataGrid useKeyboard deprecated-option mapping.
Changes:
- Removes
rowDragging.filterfrom core and framework bindings. - Removes the obsolete
useKeyboardmapping. - Updates are still required for the existing QUnit test referencing
useKeyboard.
| File | Reviewed change |
|---|---|
packages/devextreme/ts/dx.all.d.ts |
Updated aggregate declarations. |
packages/devextreme/js/common/grids.d.ts |
Removed grid filter typing. |
packages/devextreme/js/__internal/grids/data_grid/m_widget_base.ts |
Removed the stale deprecation mapping. |
packages/devextreme-vue/src/tree-list.ts |
Updated Vue TreeList bindings. |
packages/devextreme-vue/src/data-grid.ts |
Updated Vue DataGrid bindings. |
packages/devextreme-react/src/tree-list.ts |
Updated React TreeList typings. |
packages/devextreme-react/src/data-grid.ts |
Updated React DataGrid typings. |
packages/devextreme-angular/src/ui/tree-list/nested/row-dragging.ts |
Removed the Angular filter input. |
packages/devextreme-angular/src/ui/tree-list/index.ts |
Updated TreeList typings. |
packages/devextreme-angular/src/ui/nested/row-dragging.ts |
Removed the shared filter input. |
packages/devextreme-angular/src/ui/data-grid/nested/row-dragging.ts |
Removed the Angular filter input. |
packages/devextreme-angular/src/ui/data-grid/index.ts |
Updated DataGrid typings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| assert.ok($(dataGrid.getRowElement(0)).find('.dx-editor-cell').eq(0).hasClass('dx-focused'), 'first editable cell is active'); | ||
| }); | ||
|
|
||
| QUnit.test('Test mutual influence of the useKeyboard and keyboardNavigation.enabled options', function(assert) { |
There was a problem hiding this comment.
options were synced by deprecatedOptions alias: https://github.com/DevExpress/DevExtreme/pull/35277/changes#diff-565aaaaaa2c578ad8b2da454284987cac0505275d5e33bfdceccc7a68a00fc6cL155
|
|
rowDragging.filterwas defined in grids.d.ts, but was never explicitly used in DataGrid/TreeList, it defined only to allow propagation of this option to Sortable component. Howevewr, for DataGrid/TreeList this option doesn't have much sense, so it was marked deprecated before and removed.useKeyboardoption was removed long time ago, however there was leftover in deprecatedOptions, which is removed by this PR