Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fix the unavailable suspendColumnSources call before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Moves column-option filter synchronization into FilterSyncController.
Changes:
- Extracts column-property parsing into utilities.
- Delegates synchronization from the data-controller extender.
- Adds utility and synchronization tests.
A critical issue remains: m_filter_sync.ts calls an unavailable suspendColumnSources method.
File summaries
| File | Summary |
|---|---|
packages/devextreme/js/__internal/grids/grid_core/filter_sync/utils.ts |
Adds column-property parsing. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/m_filter_sync.ts |
Centralizes column-option synchronization. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/extenders/filter_sync_data_controller.ts |
Delegates column changes to the controller. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/__tests__/utils.test.ts |
Tests property parsing. |
packages/devextreme/js/__internal/grids/grid_core/filter_sync/__tests__/filter_sync.sync_column_option.test.ts |
Tests synchronization scenarios. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alyar666
force-pushed
the
gridcore_move_column_sync_to_filter_sync_26_2
branch
from
September 17, 2026 18:55
42e57a8 to
ec3901d
Compare
Alyar666
force-pushed
the
gridcore_move_column_sync_to_filter_sync_26_2
branch
from
September 17, 2026 19:21
ec3901d to
125699c
Compare
bit-byte0
reviewed
Sep 22, 2026
| || previousValue === FILTER_TYPES_EXCLUDE; | ||
| const isExcludeFilterTypeToggled = propertyName === 'filterType' && hasExcludeFilterType; | ||
| const needSyncHeaderFilter = isExcludeFilterTypeToggled || propertyName === 'filterValues'; | ||
| const needSyncFilterRow = propertyName === 'filterValue' |
Contributor
There was a problem hiding this comment.
would a small typed union for propertyName read better here than the 'filterValue' / 'filterValues' / 'filterType' string comparisons, or do you see it as churn since this moved over verbatim from the data extender?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.