Manchester | 26-ITP-Sep |Precious Moses | Sprint 3 | Course-work-3 by moses77-boop · Pull Request #1585 · CodeYourFuture/Module-JavaScript-Fundamentals

moses77-boop · 2026-09-24T18:27:18Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Completed all tasks including using predictions, reusing functions,understanding strings, invoking methods, BMI Calculation, time formatting and checks, conversion programs, using Python tutor code visualizer, and debugging

…ood Morning"

…rd in passwordChecker.js

… formatting

…rror handling

…s for various time formats and edge cases

netlify · 2026-09-24T18:27:24Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`8613d97`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab5ca065a9e42000820618e
😎 Deploy Preview	https://deploy-preview-1585--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

iscmiguelsamaniego

Fantastic work on this! Using a regular expression for validation and writing such comprehensive test assertions makes this solution extremely robust. Great job overall—approved!

iscmiguelsamaniego · 2026-09-24T22:36:06Z

Hello! Great job fixing the scope error.

Quick question: since the template string already produces the exact result you need, could you return it directly without reassigning the parameter, and how might that improve code simplicity?

Thanks for feedback! I think I might have got carried away. I fixed it.
It would improve code simplicity as it cuts out an unnecessary step.

iscmiguelsamaniego · 2026-09-24T22:36:40Z

Great job spotting the scope conflict and fixing the code.

Quick question: since decimalNumber * 100 is already a short expression, could you return it directly inside the template string without declaring a separate percentage variable?

Thanks for the feedback. I just enjoy adding more details to my code

I fixed it.

iscmiguelsamaniego · 2026-09-24T22:37:21Z

Hello! Great job identifying why passing a number literal in a function definition causes a SyntaxError and fixing it with a proper parameter name.

Quick question: when naming parameters like n, how could choosing a more descriptive name (like number) help anyone reading your code understand its purpose even faster?

iscmiguelsamaniego · 2026-09-24T22:37:50Z

Hello! Great job tracing the execution order and explaining why functions without a return statement default to returning undefined.

Quick question: since the function now uses return a * b, why is returning the value rather than using console.log inside the function considered a best practice in JavaScript?

Thanks for the feedback!
Using return is considered as best practice because a function that only uses 'console.log' would not be able to parse output in an expression, but a function that returns a value stays flexible, I could choose not to log it.

iscmiguelsamaniego · 2026-09-24T22:38:21Z

Hello! Great job spotting how automatic semicolon insertion affects the return statement and fixing it.

Quick question: since the expression a + b is short and simple, why might keeping it on the same line as return (like return a + b;) be preferred over putting it on a new line inside parentheses?

Thanks for the feedback. I enjoy detailing my code. I'll fix it.

iscmiguelsamaniego · 2026-09-24T22:39:25Z

Hello! Great job writing the calculateBMI function, handling edge cases for height, and using .toFixed(1) to return a clean string.

Quick question: since .toFixed() converts the number into a string, how might that affect any downstream code if another function tries to perform further mathematical calculations directly on the result of calculateBMI?

Thanks for the feedback!
From research using turns into a string, rather than real numbers, so if further mathematical calculations are peformed directly on that result in some cases, it produces the wrong answer by joining the values together as text instead of adding them numerically and in other cases it fails strict equality comparison since a string and a number are never treated as equal.
I have made changes to the code so it can handle further mathematical calculations.

iscmiguelsamaniego · 2026-09-24T22:39:54Z

Hello! Great job writing a robust function that handles extra spaces and validates the input type.

Quick question: since this is a fundamentals exercise, do you think using a regular expression like /\s+/ is necessary, or could a simpler method like .replaceAll() achieve the same result?

iscmiguelsamaniego · 2026-09-24T22:40:49Z

Hello! Great job transforming the snippet into a reusable function and effectively handling different input lengths using string methods like padStart and padEnd.

Quick question: since your logic relies on removing the trailing 'p', how might your function behave if an input accidentally omits the 'p' or includes extra whitespace?

iscmiguelsamaniego · 2026-09-24T22:41:19Z

Hello! Great job tracing the execution step by step and using temporary tracking variables to verify your answers.

Quick question: while using global variables helped you trace the code here, why can relying on global variables for tracking state be risky in larger applications?

iscmiguelsamaniego · 2026-09-24T22:41:49Z

Hello! Great job writing thorough edge-case tests and using regular expressions to safely validate the 24-hour time format.

Quick question: since you added robust error handling and comprehensive test assertions, how does writing these tests before or alongside your implementation help you catch unexpected bugs earlier?

moses77-boop added 30 commits September 14, 2026 10:29

Add hello_world.js file

1d8957c

Add hello_world.js file with initial console log

cb5fd1c

Add fact.js file

3dcb7b7

Add fun fact about sprints to fact.js

14998ae

Rename file fact.js to facts.js

4b9c01a

Add greeting.js file

386a826

Add greeting message to greeting.js

ed354a3

Add console log for greeting message in greeting.js

02c297f

Update greeting message to include name in greeting.js

d3c778f

Change greeting variable from const to let and update its value to "G…

0411379

…ood Morning"

Add boolean.js file

c6ad8eb

Add boolean.js with initial console log comparisons

d2880fb

Add additional comparison console logs in boolean.js

2bddb02

Add passwordChecker.js file

3f06814

Add password validation logic in passwordChecker.js

1b3d99b

Add else statement to password validation logic

56326fb

Update userInput for password validation test

cae8927

Add adminPassword variable in passwordChecker.js

ad792cd

Add else if condition to password validation logic in passwordChecker.js

31d8426

Add exercise.js file

0f097a3

Remove unused exercise.js file

1d56388

Add response variable declaration in passwordChecker.js

220a714

Update else condition to assign response message for incorrect passwo…

762e97f

…rd in passwordChecker.js

Log response message for incorrect password in passwordChecker.js

39b87c3

Change response declaration from const to let in passwordChecker.js

3a1178c

Add prediction comment explaining SyntaxError in 0.js

9558f43

Call the capitalise function with a test string

667b02a

Add comment about SyntaxError in 0.js

0dcdd7f

Add explanation for SyntaxError in capitalise function

f76aa55

Refactor capitalise function to avoid SyntaxError by renaming variable

5433734

moses77-boop added 9 commits September 23, 2026 19:18

Implement pad function to track last num value

36e4464

Add explanation for last call to pad function

9953c8b

Comment out lastNum variable and its assignment in pad function

ad65ef3

Implement function to track last pad return value

4f756c0

Add explanation for return value of last pad call

c5f7033

Comment out formatAs12HourClock function and its related assertions

bfbaf1b

Implement formatAs12HourClock function with input validation and time…

6fc17ad

… formatting

Add check functions for formatAs12HourClock to validate outputs and e…

38ee172

…rror handling

Refactor formatAs12HourClock function and add comprehensive test case…

c72aac2

…s for various time formats and edge cases

This comment has been minimized.

Sign in to view

moses77-boop added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

Delete prep/boolean.js

ebe4d77

moses77-boop added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

moses77-boop added 2 commits September 24, 2026 19:36

Delete prep/facts.js

be45ad6

Delete prep directory

42c8e32

moses77-boop added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 24, 2026

iscmiguelsamaniego approved these changes Sep 24, 2026

View reviewed changes

moses77-boop added 6 commits September 25, 2026 00:36

Refactor capitalise function to remove unnecessary variable assignment

a818573

Refactor convertToPercentage function to simplify return statement

117c886

Rename parameter in square function for clarity

ce0df58

Fix sum function return statement formatting for clarity

ca134f6

Refactor calculateBMI function to directly return BMI value

b5f6fa6

Add BMI calculation with structuring

8613d97

Uh oh!

Conversation

moses77-boop commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Uh oh!

netlify Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

iscmiguelsamaniego left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moses77-boop Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

moses77-boop commented Sep 24, 2026 •

edited

Loading

netlify Bot commented Sep 24, 2026 •

edited

Loading

moses77-boop Sep 25, 2026 •

edited

Loading