fix(desktop): keep terminal close ownership with the window showing the panel

Author: waleedlatif1

apps/desktop/src/main/terminal/index.ts

@@ -635,11 +635,15 @@ export class TerminalService {
 
   /**
    * Whether one renderer may close a tab. The strip that lists shells sits
-   * outside the terminal panel, so the shell need not be on screen; IPC has
-   * already checked that the renderer is on the shell's chat.
+   * outside the terminal panel, so a renderer on the chat may close a shell
+   * nobody is displaying; while a window does display the panel, only that
+   * window may close, so a second window on the same chat cannot end a shell
+   * someone is using.
    */
   acceptsUserClose(owner: WebContents, terminalId: string): boolean {
-    return !owner.isDestroyed() && this.sessions.has(terminalId)
+    if (owner.isDestroyed() || !this.sessions.has(terminalId)) return false
+    const shown = this.visibleOwner && !this.visibleOwner.isDestroyed() ? this.visibleOwner : null
+    return shown === null || shown === owner
   }
 
   /** Drops the claim and unsubscribes from the owner's lifecycle. */

apps/desktop/src/main/terminal/registry.test.ts

@@ -631,13 +631,18 @@ describe('TerminalRegistry', () => {
       removeListener: vi.fn(),
     }
     const gone = { ...owner, isDestroyed: () => true }
+    const other = { ...owner, once: vi.fn(), on: vi.fn(), removeListener: vi.fn() }
 
     // The strip lives outside the panel, so a hidden shell is still closable.
     expect(terminals.closeUserTerminal('chat-B', '1', owner as never)).toEqual({
       tabs: [],
       activeTerminalId: null,
     })
     expect(terminals.closeUserTerminal('chat-A', first, gone as never).tabs).toHaveLength(2)
+    // While another window displays the panel, only that window may close.
+    terminals.setPanelVisible('chat-A', true, other as never)
+    expect(terminals.closeUserTerminal('chat-A', first, owner as never).tabs).toHaveLength(2)
+    terminals.setPanelVisible('chat-A', false, other as never)
 
     const closed = terminals.closeUserTerminal('chat-A', first, owner as never)
     expect(closed.tabs).toHaveLength(1)